From: Pratyush Anand <panand@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: rmk@armlinux.org.uk, horms@verge.net.au, kexec@lists.infradead.org
Subject: Re: [PATCH] kexec: (bugfix) mem_regions_sort()
Date: Fri, 29 Jul 2016 13:55:37 +0530 [thread overview]
Message-ID: <20160729082537.GA28046@localhost.localdomain> (raw)
In-Reply-To: <20160729082323.12253-1-takahiro.akashi@linaro.org>
On 29/07/2016:05:23:23 PM, AKASHI Takahiro wrote:
> The third argument of qsort() must be the size of each array element.
Yes, I had sent it day before yesterday which has been ACKed by Russell.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> kexec/mem_regions.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kexec/mem_regions.c b/kexec/mem_regions.c
> index e61c074..a8cb510 100644
> --- a/kexec/mem_regions.c
> +++ b/kexec/mem_regions.c
> @@ -24,7 +24,7 @@ static int mem_range_cmp(const void *a1, const void *a2)
> */
> void mem_regions_sort(struct memory_ranges *ranges)
> {
> - qsort(ranges->ranges, ranges->size, sizeof(ranges->ranges),
> + qsort(ranges->ranges, ranges->size, sizeof(ranges->ranges[0]),
> mem_range_cmp);
> }
>
> --
> 2.9.0
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-07-29 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 8:23 [PATCH] kexec: (bugfix) mem_regions_sort() AKASHI Takahiro
2016-07-29 8:25 ` Pratyush Anand [this message]
2016-08-01 4:32 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729082537.GA28046@localhost.localdomain \
--to=panand@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=rmk@armlinux.org.uk \
--cc=takahiro.akashi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.