From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53922)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1bT5FR-0006Ct-LE
	for qemu-devel@nongnu.org; Fri, 29 Jul 2016 06:42:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1bT5FM-0005Ie-Mz
	for qemu-devel@nongnu.org; Fri, 29 Jul 2016 06:42:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1bT5FM-0005IX-HF
	for qemu-devel@nongnu.org; Fri, 29 Jul 2016 06:42:28 -0400
Date: Fri, 29 Jul 2016 16:12:12 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20160729104212.GC27202@grmbl.mre>
References: <1469785705-16670-1-git-send-email-den@openvz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1469785705-16670-1-git-send-email-den@openvz.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] migration: mmap error check fix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, Evgeny Yakovlev <eyakovlev@virtuozzo.com>, Juan Quintela <quintela@redhat.com>

On (Fri) 29 Jul 2016 [12:48:25], Denis V. Lunev wrote:
> From: Evgeny Yakovlev <eyakovlev@virtuozzo.com>
> 
> mmap man page:
> "On success, mmap() returns a pointer to the mapped area. On error, the
> value MAP_FAILED (that is, (void *) -1) is returned, and errno  is  set
> to indicate the cause of the error."
> 
> The check in postcopy_get_tmp_page is definitely wrong and should be
> fixed.
> 
> Signed-off-by: Evgeny Yakovlev <eyakovlev@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Amit Shah <amit.shah@redhat.com>

Reviewed-by: Amit Shah <amit.shah@redhat.com>

		Amit