From: Jean Delvare <jdelvare@suse.de>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] i2c: i801: use BIT() macro for bits definition
Date: Fri, 29 Jul 2016 11:35:14 +0200 [thread overview]
Message-ID: <20160729113514.20b693f5@endymion> (raw)
In-Reply-To: <1469699443-22129-4-git-send-email-benjamin.tissoires@redhat.com>
On Thu, 28 Jul 2016 11:50:41 +0200, Benjamin Tissoires wrote:
> i801 mixes hexadecimal and decimal values for defining bits. However,
> we have a nice BIT() macro for this exact purpose.
Looks good to me. But maybe we could convert all the FEATURE_* defines
as well?
> No functional changes, cleanup only.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> drivers/i2c/busses/i2c-i801.c | 50 +++++++++++++++++++++----------------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
> (...)
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-07-29 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 9:50 [PATCH 0/5] i2c: Host Notify / i801 fixes Benjamin Tissoires
2016-07-28 9:50 ` [PATCH 1/5] i2c: i2c-smbus: prevent races on remove when Host Notify is used Benjamin Tissoires
2016-07-29 9:12 ` Jean Delvare
2016-07-29 16:30 ` Benjamin Tissoires
2016-08-01 13:32 ` Jean Delvare
2016-08-19 13:25 ` Benjamin Tissoires
2016-07-28 9:50 ` [PATCH 2/5] i2c: i801: minor formatting issues Benjamin Tissoires
2016-07-29 9:13 ` Jean Delvare
2016-07-28 9:50 ` [PATCH 3/5] i2c: i801: use BIT() macro for bits definition Benjamin Tissoires
2016-07-29 9:35 ` Jean Delvare [this message]
2016-07-28 9:50 ` [PATCH 4/5] i2c: i801: do not report an error if FEATURE_HOST_NOTIFY is not set Benjamin Tissoires
2016-07-29 10:40 ` Jean Delvare
2016-07-28 9:50 ` [PATCH 5/5] i2c: i801: warn on i2c_handle_smbus_host_notify() errors Benjamin Tissoires
2016-08-01 14:14 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729113514.20b693f5@endymion \
--to=jdelvare@suse.de \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.