All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] parent in ->d_compare() arguments
Date: Sun, 31 Jul 2016 00:52:15 +0100	[thread overview]
Message-ID: <20160730235215.GA2356@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFzVhMs6dArj=yNepAQesc=Lygjj09=7eEhMG_GO4y8tGg@mail.gmail.com>

On Sat, Jul 30, 2016 at 04:36:17PM -0700, Linus Torvalds wrote:

> So? Aren't they in the same cacheline?

Yes (unless lockdep map is stuck in between, in which case we are slow as
hell anyway).

> We've tried very hard to pack all those initial elements next to each other.
> 
> The first-order approximation is that number of cacheline accesses
> matter. And then the second order is to make code small and avoid
> extra instructions.
> 
> As far as I can tell, your change doesn't actually help the cacheline
> accesses, and it makes the code bigger and have extra instructions. So
> it doesn't appear to improve anything, and it does make things worse.
> 
> But numbers talk, bullshit walks. If you have numbers to show
> something different, that trumps my looking at code.

I'll profile and post the results; not today, though - it's not urgent anyway,
and right now I wouldn't trust my ability to do anything other than crawl to
the bed and hopefully get some sleep (RDU -> BOS -> RDU, on top of 4 hours of
sleep tonight and bloody two hours of delay in plane on the way back due to
bad weather; picking the younger kid from summer STEM camp had been...
interesting, for the lack of adequate printable words)

      reply	other threads:[~2016-07-31  1:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-30  1:07 [RFC] parent in ->d_compare() arguments Al Viro
2016-07-30 20:44 ` Linus Torvalds
2016-07-30 23:30   ` Al Viro
2016-07-30 23:36     ` Linus Torvalds
2016-07-30 23:52       ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160730235215.GA2356@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.