From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Subject: Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO Date: Sun, 31 Jul 2016 08:23:04 -0400 Message-ID: <20160731082304.05f4aad7@mschwide> References: <1469462394-8970-1-git-send-email-james.hogan@imgtec.com> <1469462394-8970-5-git-send-email-james.hogan@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:14739 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752953AbcGaMYf (ORCPT ); Sun, 31 Jul 2016 08:24:35 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6VCJ1Fq134928 for ; Sun, 31 Jul 2016 08:23:14 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0b-001b2d01.pphosted.com with ESMTP id 24grcjw7dc-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sun, 31 Jul 2016 08:23:14 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 31 Jul 2016 13:23:13 +0100 In-Reply-To: <1469462394-8970-5-git-send-email-james.hogan@imgtec.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: James Hogan Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Heiko Carstens , linux-s390@vger.kernel.org On Mon, 25 Jul 2016 16:59:53 +0100 James Hogan wrote: > AT_VECTOR_SIZE_ARCH should be defined with the maximum number of > NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined > for s390 at all even though ARCH_DLINFO can contain one NEW_AUX_ENT when > VDSO is enabled. > > This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for > AT_BASE_PLATFORM which s390 doesn't use, but lets define it now and add > the comment above ARCH_DLINFO as found in several other architectures to > remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to > date. > > Fixes: b020632e40c3 ("[S390] introduce vdso on s390") > Signed-off-by: James Hogan > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s390@vger.kernel.org The patch makes sense. I not quite sure about the checkpoint-restore code that clears the last two entries of the user_auxv[] without knowing how many aux entries there really are. That seems kind of strange. I will the patch to our repositories and we'll give it a spin. If there is no fallout I queue it to linux-s390. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753633AbcGaNXA (ORCPT ); Sun, 31 Jul 2016 09:23:00 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39106 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752784AbcGaNWz (ORCPT ); Sun, 31 Jul 2016 09:22:55 -0400 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: schwidefsky@de.ibm.com X-IBM-RcptTo: linux-arch@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Sun, 31 Jul 2016 08:23:04 -0400 From: Martin Schwidefsky To: James Hogan Cc: , , Heiko Carstens , Subject: Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO In-Reply-To: <1469462394-8970-5-git-send-email-james.hogan@imgtec.com> References: <1469462394-8970-1-git-send-email-james.hogan@imgtec.com> <1469462394-8970-5-git-send-email-james.hogan@imgtec.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16073112-0012-0000-0000-0000043D01B0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16073112-0013-0000-0000-000014DD9460 Message-Id: <20160731082304.05f4aad7@mschwide> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-31_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607310138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jul 2016 16:59:53 +0100 James Hogan wrote: > AT_VECTOR_SIZE_ARCH should be defined with the maximum number of > NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined > for s390 at all even though ARCH_DLINFO can contain one NEW_AUX_ENT when > VDSO is enabled. > > This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for > AT_BASE_PLATFORM which s390 doesn't use, but lets define it now and add > the comment above ARCH_DLINFO as found in several other architectures to > remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to > date. > > Fixes: b020632e40c3 ("[S390] introduce vdso on s390") > Signed-off-by: James Hogan > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s390@vger.kernel.org The patch makes sense. I not quite sure about the checkpoint-restore code that clears the last two entries of the user_auxv[] without knowing how many aux entries there really are. That seems kind of strange. I will the patch to our repositories and we'll give it a spin. If there is no fallout I queue it to linux-s390. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.