Re: [PATCH] libxl: compilation warning fix for arm & aarch64

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Jul 28, 2016 at 11:09:41AM +0100, Wei Liu wrote:
> On Wed, Jul 27, 2016 at 04:01:26PM -0400, Chris Patterson wrote:
> > From: Chris Patterson <pattersonc@ainfosec.com>
> > 
> > GCC 6 will warn on unused static const variables in c modules:
> > https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00847.html
> > 
> > When compiling with LIBXL_HAVE_NO_SUSPEND_RESUME set (arm & aarch64),
> > the compiler emits the following errors:
> >   xl_cmdimpl.c:101:19: error: 'migrate_report'
> >       defined but not used [-Werror=unused-const-variable=]
> >   xl_cmdimpl.c:99:19: error: 'migrate_permission_to_go'
> >       defined but not used [-Werror=unused-const-variable=]
> >   xl_cmdimpl.c:97:19: error: 'migrate_receiver_ready'
> >       defined but not used [-Werror=unused-const-variable=]
> >   xl_cmdimpl.c:95:19: error: 'migrate_receiver_banner'
> >       defined but not used [-Werror=unused-const-variable=]
> > 
> > These unused const variables are only used in functions which exist between
> > the ifndef block:
> >    #ifndef LIBXL_HAVE_NO_SUSPEND_RESUME
> >    ...
> >    #endif
> > 
> > Wrap the same ifndef around these variables.
> > 
> > Signed-off-by: Chris Patterson <pattersonc@ainfosec.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 

Pushed.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel