diff for duplicates of <20160801110308.GC16141@lst.de> diff --git a/a/1.txt b/N1/1.txt index 568922e..4acad0c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Fri, Jul 29, 2016@10:57:19PM +0300, Sagi Grimberg wrote: +On Fri, Jul 29, 2016 at 10:57:19PM +0300, Sagi Grimberg wrote: > If we wait until we free the controller (free_ctrl) we might > lose our rdma device without any notification while we still > have open resources (tags mrs and dma mappings). @@ -10,8 +10,8 @@ On Fri, Jul 29, 2016@10:57:19PM +0300, Sagi Grimberg wrote: > controller reset uses it as well and we want to give active I/O > a chance to complete successfully. > -> Reported-by: Steve Wise <swise at opengridcomputing.com> -> Signed-off-by: Sagi Grimberg <sagi at grimberg.me> +> Reported-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org> +> Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> This looks fine to me, but can we place share the code instead of duplicating it? E.g. @@ -32,3 +32,7 @@ static void __nvme_rdma_remove_ctrl(struct nvme_rdma_ctrl *ctrl, bool shutdown) or in a second step we should probably always call shutdown_ctrl but skip the actual shutdown if the ctrl state doesn't require it. +-- +To unsubscribe from this list: send the line "unsubscribe linux-rdma" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index ca8f3a2..0bb07dc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,11 +1,19 @@ "ref\01469822242-3477-1-git-send-email-sagi@grimberg.me\0" "ref\01469822242-3477-3-git-send-email-sagi@grimberg.me\0" - "From\0hch@lst.de (Christoph Hellwig)\0" - "Subject\0[PATCH 2/5] nvme-rdma: Free the I/O tags when we delete the controller\0" + "ref\01469822242-3477-3-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org\0" + "From\0Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>\0" + "Subject\0Re: [PATCH 2/5] nvme-rdma: Free the I/O tags when we delete the controller\0" "Date\0Mon, 1 Aug 2016 13:03:08 +0200\0" + "To\0Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>\0" + "Cc\0linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" + linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org> + Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> + Jay Freyensee <james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> + " Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>\0" "\00:1\0" "b\0" - "On Fri, Jul 29, 2016@10:57:19PM +0300, Sagi Grimberg wrote:\n" + "On Fri, Jul 29, 2016 at 10:57:19PM +0300, Sagi Grimberg wrote:\n" "> If we wait until we free the controller (free_ctrl) we might\n" "> lose our rdma device without any notification while we still\n" "> have open resources (tags mrs and dma mappings).\n" @@ -17,8 +25,8 @@ "> controller reset uses it as well and we want to give active I/O\n" "> a chance to complete successfully.\n" "> \n" - "> Reported-by: Steve Wise <swise at opengridcomputing.com>\n" - "> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>\n" + "> Reported-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>\n" + "> Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>\n" "\n" "This looks fine to me, but can we place share the code instead of\n" "duplicating it? E.g.\n" @@ -38,6 +46,10 @@ "}\n" "\n" "or in a second step we should probably always call shutdown_ctrl\n" - but skip the actual shutdown if the ctrl state doesn't require it. + "but skip the actual shutdown if the ctrl state doesn't require it.\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-rdma\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -136f53bfa8cd764bc43830db9cb60229ed3bfd04d59799ff0f8f6a3bc46248fd +7e82edab9dfe24945a9abe5fe2678d451977679918e7a2b99b47197dcad7fea5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.