From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Mon, 1 Aug 2016 13:06:04 +0200 Subject: [PATCH 4/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces In-Reply-To: <1469822242-3477-5-git-send-email-sagi@grimberg.me> References: <1469822242-3477-1-git-send-email-sagi@grimberg.me> <1469822242-3477-5-git-send-email-sagi@grimberg.me> Message-ID: <20160801110604.GE16141@lst.de> > - nvme_remove_namespaces(&ctrl->ctrl); > - nvme_rdma_shutdown_ctrl(ctrl); > nvme_uninit_ctrl(&ctrl->ctrl); > + nvme_rdma_shutdown_ctrl(ctrl); How safe is the reordering here? The description should explain why it's fine. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 4/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces Date: Mon, 1 Aug 2016 13:06:04 +0200 Message-ID: <20160801110604.GE16141@lst.de> References: <1469822242-3477-1-git-send-email-sagi@grimberg.me> <1469822242-3477-5-git-send-email-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1469822242-3477-5-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Steve Wise , Christoph Hellwig , Jay Freyensee , Jens Axboe List-Id: linux-rdma@vger.kernel.org > - nvme_remove_namespaces(&ctrl->ctrl); > - nvme_rdma_shutdown_ctrl(ctrl); > nvme_uninit_ctrl(&ctrl->ctrl); > + nvme_rdma_shutdown_ctrl(ctrl); How safe is the reordering here? The description should explain why it's fine. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html