From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Mon, 1 Aug 2016 17:47:17 +0200 Subject: [PATCH 2/5] nvme-rdma: Free the I/O tags when we delete the controller In-Reply-To: References: <1469822242-3477-1-git-send-email-sagi@grimberg.me> <1469822242-3477-3-git-send-email-sagi@grimberg.me> <20160801110308.GC16141@lst.de> Message-ID: <20160801154717.GA22771@lst.de> On Mon, Aug 01, 2016@02:15:59PM +0300, Sagi Grimberg wrote: >> or in a second step we should probably always call shutdown_ctrl >> but skip the actual shutdown if the ctrl state doesn't require it. > > What do you mean "if the ctrl state doesn't require it"? > Up until today we managed to avoid checking the ctrl state > in queue_rq and I'd like to keep it that way. I'd be much > happier if we don't depend on queue_rq to fail early under > some assumptions, it might be a slippery slope... In this case I actually thought about checking the state in the new __nvme_rdma_remove_ctrl. If called from nvme_rdma_del_ctrl_work the state will be NVME_CTRL_DELETING, so we can check that to see if we want to do a controlled shutdown using nvme_rdma_shutdown_ctrl instead of having to overwrite ->remove_work. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/5] nvme-rdma: Free the I/O tags when we delete the controller Date: Mon, 1 Aug 2016 17:47:17 +0200 Message-ID: <20160801154717.GA22771@lst.de> References: <1469822242-3477-1-git-send-email-sagi@grimberg.me> <1469822242-3477-3-git-send-email-sagi@grimberg.me> <20160801110308.GC16141@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: Christoph Hellwig , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Steve Wise , Jay Freyensee , Jens Axboe List-Id: linux-rdma@vger.kernel.org On Mon, Aug 01, 2016 at 02:15:59PM +0300, Sagi Grimberg wrote: >> or in a second step we should probably always call shutdown_ctrl >> but skip the actual shutdown if the ctrl state doesn't require it. > > What do you mean "if the ctrl state doesn't require it"? > Up until today we managed to avoid checking the ctrl state > in queue_rq and I'd like to keep it that way. I'd be much > happier if we don't depend on queue_rq to fail early under > some assumptions, it might be a slippery slope... In this case I actually thought about checking the state in the new __nvme_rdma_remove_ctrl. If called from nvme_rdma_del_ctrl_work the state will be NVME_CTRL_DELETING, so we can check that to see if we want to do a controlled shutdown using nvme_rdma_shutdown_ctrl instead of having to overwrite ->remove_work. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html