From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Mon, 1 Aug 2016 17:50:36 +0200 Subject: [PATCH 2/2] nvme-rdma: Add handling for connecting to IPv6 targets In-Reply-To: References: <1469950060-18098-1-git-send-email-roland@kernel.org> <1469950060-18098-2-git-send-email-roland@kernel.org> <4acdd466-b8f6-8208-7287-e97dfd45bbf1@grimberg.me> <33dfc646-1804-363e-4d83-1ba618303dbb@grimberg.me> <20160801110956.GI16141@lst.de> Message-ID: <20160801155036.GC22771@lst.de> On Mon, Aug 01, 2016@02:24:10PM +0300, Sagi Grimberg wrote: > >>> Currently the target driver doesn't support ipv6 addresses. >>> >>> These complementary patches [1,2] makes the it work e2e! So, >> >> I think we should use the same ipv6 addr parsing that Roland used >> in the host, and preferably have another module export that as a helper. > > I can try to unify them, but unlike the host that first tries ipv4 and > then fall to ipv6, the target needs to enforce the address family so > it's somewhat different. I kinda think that these are different enough > to stay separate don't you think? It'd still need all the scope ID handling similar to what Roland did, and that's a fair chunk of code. We have a few options to handle the different allowed addresses: (1) v4/v6 only flags (2) having low-level v4/v6 handlers and one that tries these both (3) using the try both handler and rejecting the wrong one after parsing. (3) seems easiest, but (2) sounds fine to me. But I'd really like to hear from folks on the netdev list what they think of that idea first. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2] nvme-rdma: Add handling for connecting to IPv6 targets Date: Mon, 1 Aug 2016 17:50:36 +0200 Message-ID: <20160801155036.GC22771@lst.de> References: <1469950060-18098-1-git-send-email-roland@kernel.org> <1469950060-18098-2-git-send-email-roland@kernel.org> <4acdd466-b8f6-8208-7287-e97dfd45bbf1@grimberg.me> <33dfc646-1804-363e-4d83-1ba618303dbb@grimberg.me> <20160801110956.GI16141@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: Christoph Hellwig , Roland Dreier , Jens Axboe , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Mon, Aug 01, 2016 at 02:24:10PM +0300, Sagi Grimberg wrote: > >>> Currently the target driver doesn't support ipv6 addresses. >>> >>> These complementary patches [1,2] makes the it work e2e! So, >> >> I think we should use the same ipv6 addr parsing that Roland used >> in the host, and preferably have another module export that as a helper. > > I can try to unify them, but unlike the host that first tries ipv4 and > then fall to ipv6, the target needs to enforce the address family so > it's somewhat different. I kinda think that these are different enough > to stay separate don't you think? It'd still need all the scope ID handling similar to what Roland did, and that's a fair chunk of code. We have a few options to handle the different allowed addresses: (1) v4/v6 only flags (2) having low-level v4/v6 handlers and one that tries these both (3) using the try both handler and rejecting the wrong one after parsing. (3) seems easiest, but (2) sounds fine to me. But I'd really like to hear from folks on the netdev list what they think of that idea first. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html