From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Use own timer for multicast TT and TVLV updates
Date: Mon, 1 Aug 2016 22:57:16 +0200 [thread overview]
Message-ID: <20160801205716.GB9200@otheros> (raw)
In-Reply-To: <6419172.04lP9a1mmf@sven-edge>
On Fri, Jul 22, 2016 at 12:19:54AM +0200, Sven Eckelmann wrote:
> On Donnerstag, 21. Juli 2016 23:59:30 CEST Sven Eckelmann wrote:
> > On Donnerstag, 21. Juli 2016 23:38:32 CEST Linus Lüssing wrote:
> > > - struct hlist_head mla_list;
> > > + struct hlist_head mla_list; /* protected by mcast.work */
> >
> > Protected by a workqueue item? How?
>
> Looks like you wanted to say here that it is only modified inside the worker
> queue (via the mcast.work delayed workqueue item) - unless it is not done this
> way like in batadv_mcast_free after cancel_delayed_work_sync.
Exactly :). I tried to "summarize" that a little to make it fit as an
inline comment ;). (although there are some further kerneldoc remarks on
the functions using it)
Is it ok now or do you think I should add something like your
explanation somewhere else?
next prev parent reply other threads:[~2016-08-01 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 21:38 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove unnecessary lockdep in batadv_mcast_mla_list_free Linus Lüssing
2016-07-21 21:38 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Use own timer for multicast TT and TVLV updates Linus Lüssing
2016-07-21 21:53 ` Linus Lüssing
2016-07-21 21:59 ` Sven Eckelmann
2016-07-21 22:19 ` Sven Eckelmann
2016-08-01 20:57 ` Linus Lüssing [this message]
2016-08-02 7:44 ` Sven Eckelmann
2016-07-21 22:01 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove unnecessary lockdep in batadv_mcast_mla_list_free Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801205716.GB9200@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.