All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF
Date: Tue, 2 Aug 2016 09:09:06 +0800	[thread overview]
Message-ID: <20160802010906.GA680@ad.usersys.redhat.com> (raw)
In-Reply-To: <abd48ab4-4fd2-9e5e-c680-cbac5396f594@redhat.com>

On Mon, 08/01 12:41, John Snow wrote:
> > -    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
> > +    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd);
> >      switch (action) {
> >          case CURL_POLL_IN:
> >              aio_set_fd_handler(s->aio_context, fd, false,
> > 
> 
> Is curl_socket_t always of type long long unsigned int? why not use %llu ?

Since it is a typedef, variation between platforms is imaginable. On Linux it
is 4 bytes, the error is only seen on Windows.

Fam


WARNING: multiple messages have this Message-ID (diff)
From: Fam Zheng <famz@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF
Date: Tue, 2 Aug 2016 09:09:06 +0800	[thread overview]
Message-ID: <20160802010906.GA680@ad.usersys.redhat.com> (raw)
In-Reply-To: <abd48ab4-4fd2-9e5e-c680-cbac5396f594@redhat.com>

On Mon, 08/01 12:41, John Snow wrote:
> > -    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
> > +    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd);
> >      switch (action) {
> >          case CURL_POLL_IN:
> >              aio_set_fd_handler(s->aio_context, fd, false,
> > 
> 
> Is curl_socket_t always of type long long unsigned int? why not use %llu ?

Since it is a typedef, variation between platforms is imaginable. On Linux it
is 4 bytes, the error is only seen on Windows.

Fam

  reply	other threads:[~2016-08-02  1:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01  5:04 [Qemu-trivial] [PATCH] curl: Cast fd to int for DPRINTF Fam Zheng
2016-08-01  5:04 ` [Qemu-devel] " Fam Zheng
2016-08-01 16:41 ` [Qemu-trivial] " John Snow
2016-08-01 16:41   ` John Snow
2016-08-02  1:09   ` Fam Zheng [this message]
2016-08-02  1:09     ` Fam Zheng
2016-08-02  2:59     ` [Qemu-trivial] " John Snow
2016-08-02  2:59       ` John Snow
2016-08-10  2:41 ` [Qemu-trivial] " Fam Zheng
2016-08-10  2:41   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802010906.GA680@ad.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.