From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUOPu-0002fJ-Pz for qemu-devel@nongnu.org; Mon, 01 Aug 2016 21:22:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUOPo-0004Ux-RB for qemu-devel@nongnu.org; Mon, 01 Aug 2016 21:22:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUOPo-0004Ur-Lh for qemu-devel@nongnu.org; Mon, 01 Aug 2016 21:22:40 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A312C05CDF3 for ; Tue, 2 Aug 2016 01:22:40 +0000 (UTC) Date: Tue, 2 Aug 2016 09:22:38 +0800 From: Fam Zheng Message-ID: <20160802012238.GC680@ad.usersys.redhat.com> References: <1469600777-30413-1-git-send-email-famz@redhat.com> <1469600777-30413-4-git-send-email-famz@redhat.com> <1470052437.30562.39.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470052437.30562.39.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Colin Lord , Paolo Bonzini On Mon, 08/01 13:53, Gerd Hoffmann wrote: > On Mi, 2016-07-27 at 14:26 +0800, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > more verbose commit message please, especially for those (like me) who > have not worked yet with modules. Yeah, my bad. Maybe I should have put RFC to the subject too. > > Will sdl be loaded unconditionally? > Or only with -display sdl? > What happens if the module is not present? Only with -display sdl, and report error + exit if the module is not present. > > The main benefit I see in modularizing the ui is that we can move the ui > modules (and the UI libs dependency chain) to a separate rpm subpackage, > can we start that with this series applied? Yes, that is the intention, but we need v2 to fix SDL audio and baum to achieve that. Colin also tested that not loading gui shared libraries (gtk?) speeds up starting up. > > Can modules have dependencies on other modules? When it comes to > modularizing spice we will need that as qxl has a spice dependency ... Yes. spice's modules init function can call module_call_init(MODULE_INIT_QXL), then check if QXL is available after that. Fam