From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [git pull] drm for v4.8 Date: Tue, 2 Aug 2016 11:10:42 +0300 Message-ID: <20160802081042.GP4329@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 319A86E402 for ; Tue, 2 Aug 2016 08:10:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Linus Torvalds , Linux Kernel Mailing List , DRI mailing list List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMDIsIDIwMTYgYXQgMTA6MDA6MTJBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEF1ZyAyLCAyMDE2IGF0IDQ6MjYgQU0sIExpbnVzIFRvcnZhbGRzCj4g PHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRpb24ub3JnPiB3cm90ZToKPiA+IE9uIE1vbiwgQXVnIDEs IDIwMTYgYXQgOTozMiBQTSwgRGF2ZSBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+IHdyb3RlOgo+ ID4+Cj4gPj4gVGhpcyBpcyB0aGUgbWFpbiBkcm0gcHVsbCByZXF1ZXN0IGZvciA0LjgsIEknbSBk b3duIHdpdGggYSBjb2xkIGF0IHRoZSBtb21lbnQKPiA+PiBzbyBob3BlZnVsbHkgdGhpcyBpc24n dCBpbiB0b28gYmFkIGEgc3RhdGUsIEkgZmluaXNoZWQgcHVsbGluZyBzdHVmZiBsYXN0Cj4gPj4g d2VlayBtb3N0bHkgKG5vdXZlYXUgZml4ZXMganVzdCB3ZW50IGluIHRvZGF5KSwgc28gb25seSB0 aGlzIG1lc3NhZ2Ugc2hvdWxkCj4gPj4gYmUgaW5mbHVlbmNlZCBieSBpbGxuZXNzLiBBcG9sb2dp ZXMgdG8gYW55b25lIHdobydzIG1ham9yIGZlYXR1cmUgSSBtaXNzZWQgOi0pCj4gPj4KPiA+PiBp OTE1Ogo+ID4+ICAgICAgICAgQlhUIHN1cHBvcnQgZW5hYmxlZCBieSBkZWZhdWx0Cj4gPj4gICAg ICAgICBHVlQtZyBpbmZyYXN0cnVjdHVyZQo+ID4+ICAgICAgICAgR3VDIGNvbW1hbmQgc3VibWlz c2lvbiBhbmQgZml4ZXMKPiA+PiAgICAgICAgIEJYVCB3b3JrYXJvdW5kcwo+ID4+ICAgICAgICAg U0tML0JLTCB3b3JrYXJvdW5kcwo+ID4+ICAgICAgICAgRGVtaWRsYXllcmluZyBkZXZpY2UgcmVn aXN0cmF0aW9uCj4gPj4gICAgICAgICBUaHVuZGVyaW5nIGhlcmQgZml4ZXMKPiA+PiAgICAgICAg IE1pc3NpbmcgcGNpIGlkcwo+ID4+ICAgICAgICAgQXRvbWljIHVwZGF0ZXMKPiA+Cj4gPiBIbW0u IEkgZGlkIHRoZSBtZXJnZSBhbmQgcHVzaGVkIGl0IG91dCwgYnV0IHRlc3RpbmcgaXQgb24gbXkg bGFwdG9wCj4gPiBzaG93cyBzb21lIHZlcnkgYW5ub3lpbmcgZmxpY2tlcmluZyBwcm9ibGVtLgo+ ID4KPiA+IFRoZSBzY3JlZW4gZ29lcyBkYXJrIGZvciBhIHZlcnkgc2hvcnQgd2hpbGUgKG9uZSBm cmFtZT8gV2hvIGtub3dzPwo+ID4gU2VlbXMgbG9uZ2VyIG9jY2FzaW9uYWxseSkuIEkgaGF2ZSBu byBpZGVhIHdoYXQgdHJpZ2dlcnMgaXQsIGJ1dCBpdAo+ID4gaGFwcGVucyBxdWl0ZSBhIGxvdCB3 aGVuIGl0IGhhcHBlbnMuIExpa2Ugb25jZSBldmVyeSBzZWNvbmQgb3IgdHdvLgo+ID4gQW5kIGl0 IHNlZW1zIHRvIGhhcHBlbiBtb3N0IG9mIHRoZSB0aW1lLCBhbHRob3VnaCByaWdodCBub3cgaXQg aGFwcGVucwo+ID4gdG8gYmUgYmVoYXZpbmcgbmljZWx5LCBzbyBzb21ldGltZXMgaXQgZ29lcyBm b3IgYSB3aGlsZSB3aXRob3V0IHRoZQo+ID4gZmxpY2tlcmluZy4KPiA+Cj4gPiBUaGluZ3MgKndv cmsqLCBidXQgdGhlIGZsaWNrZXJpbmcgaXMgbmFzdHkgZW5vdWdoIHRvIG1ha2UgdGhlIGVuZAo+ ID4gcmVzdWx0IHBhaW5mdWwgdG8gdXNlLgo+ID4KPiA+IFRoZSBvbmx5IHRoaW5nIEkgc2VlIGlu IGRtZXNnIHRoYXQgbG9va3MgYmFkIGlzCj4gPgo+ID4gICAgW2RybTppbnRlbF9zZXRfY3B1X2Zp Zm9fdW5kZXJydW5fcmVwb3J0aW5nIFtpOTE1XV0gKkVSUk9SKgo+ID4gdW5jbGVhcmVkIGZpZm8g dW5kZXJydW4gb24gcGlwZSBBCj4gPiAgICBbZHJtOmludGVsX2NwdV9maWZvX3VuZGVycnVuX2ly cV9oYW5kbGVyIFtpOTE1XV0gKkVSUk9SKiBDUFUgcGlwZSBBCj4gPiBGSUZPIHVuZGVycnVuCj4g Pgo+ID4gYnV0IEkndmUgc2VlbiB0aGF0IGJlZm9yZSwgYW5kIGl0IGhhcHBlbnMgYSBjb3VwbGUg b2YgdGltZXMgZHVyaW5nCj4gPiBib290LiBOb3Qgb25jZSBwZXIgc2Vjb25kLgo+ID4KPiA+IFRo aXMgaXMgbXkgb2xkIFZhaW8gMTEgUHJvLCBub3cgcnVubmluZyBGZWRvcmEgMjQgKHVwLXRvLWRh dGUgYXMgb2YgdG9kYXkpLgo+ID4KPiA+IFNvIGl0J3MgYm9nLXN0YW5kYXJkIGludGVsIGdyYXBo aWNzIChpNS00MjAwVSAtIEhhc3dlbGwgVUxUKS4KPiA+Cj4gPiBTdWdnZXN0aW9ucyB0byB0cnk/ Cj4gCj4gcHNyIG9yIGZiYyBhcmUgdGhlIGxpa2VseSBjdWxwcml0cy4gTW9yZSBsaWtlbHkgZmJj IGlmIHRoZSB1bmRlcnJ1bnMKPiBjb3JyZWxhdGUgd2l0aCB0aGUgZmxpY2tlciAoYnV0IG5vdGUg dGhhdCBieSBkZWZhdWx0IHdlIG9ubHkgcmVwb3J0Cj4gdGhlbSBvbmNlIHBlciBtb2Rlc3QsIG5l ZWRzIHRvIGJlIHJlc2V0IHdpdGggYSBkcG1zIG9yCj4gc3VzcGVuZC9yZXN1bWUpLiBEcml2ZXIg c2hvdWxkIGV2ZW4gcGljayB1cCB0aGUgbmV3IG1vZHVsZSBvcHRpb24KPiBzZXR0aW5ncyBhdCBy dW50aW1lIChidXQgYWdhaW4geW91IG5lZWQgdG8gZm9yY2UgYSBtb2Rlc2V0LCBqdXN0Cj4gc3Vz cGVuZC9yZXN1bWUgcXVpY2tseSksIHNvIGZhc3QgdG8gdGVzdC4KCkkgdGhpbmsgRkJDIGlzIHN0 aWxsIGRpc2FibGVkIGJ5IGRlZmF1bHQgb24gSFNXLgoKU28gUFNSIHNlZW1zIG1vcmUgbGlrZWx5 LiBUaGUgdW5kZXJydW5zIG1pZ2h0IHBvaW50IGF0IHNvbWUgd2F0ZXJtYXJrCmZhaWwgdGhvdWdo IDooCgpJIGhhdmUgYSBjb3VwbGUgb2YgcGVuZGluZyBQU1IgcGF0Y2hlcyB5b3UgbWF5IHdhbnQg dG8gdHJ5IGFzIHdlbGwsCmlmIGk5MTUuZW5hYmxlX3Bzcj0wIGhlbHBzLgoKRmlyc3Qgc2V0IGlz IGhlcmU6CmdpdDovL2dpdGh1Yi5jb20vdnN5cmphbGEvbGludXguZ2l0IHBzcl9zZXR1cF90aW1l XzIKVGhpcyBzaG91bGQgYmUgcGVyZmVjdGx5IHNhZmUgdG8gZ28gaW4gYWN0dWFsbHksIGFzIGl0 IHdpbGwgb25seSByZXN1bHQKaW4gZGlzYWJsaW5nIFBTUiB3aXRoIGNlcnRhaW4gcGFuZWxzLgoK VGhlIHNlY29uZCBzZXQgaXMgaGVyZToKZ2l0Oi8vZ2l0aHViLmNvbS92c3lyamFsYS9saW51eC5n aXQgcHNyX2ZpeGVzXzIKVGhpcyBvbmUgSSB0aGluayBpcyBjYXVzaW5nIHNvbWUga2luZCBvZiBz bGlnaHQgcmVncmVzc2lvbiBvbiBvbmUKbWFjaGluZSBpbiBvdXIgQ0kgc3lzdGVtLiBTdGlsbCBu b3Qgc3VyZSB3aGF0J3MgZ29pbmcgb24gdGhlcmUuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbcHBIML (ORCPT ); Tue, 2 Aug 2016 04:12:11 -0400 Received: from mga09.intel.com ([134.134.136.24]:23020 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbcHBIMA (ORCPT ); Tue, 2 Aug 2016 04:12:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1033479431" Date: Tue, 2 Aug 2016 11:10:42 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Daniel Vetter Cc: Linus Torvalds , Daniel Vetter , DRI mailing list , Linux Kernel Mailing List Subject: Re: [git pull] drm for v4.8 Message-ID: <20160802081042.GP4329@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 10:00:12AM +0200, Daniel Vetter wrote: > On Tue, Aug 2, 2016 at 4:26 AM, Linus Torvalds > wrote: > > On Mon, Aug 1, 2016 at 9:32 PM, Dave Airlie wrote: > >> > >> This is the main drm pull request for 4.8, I'm down with a cold at the moment > >> so hopefully this isn't in too bad a state, I finished pulling stuff last > >> week mostly (nouveau fixes just went in today), so only this message should > >> be influenced by illness. Apologies to anyone who's major feature I missed :-) > >> > >> i915: > >> BXT support enabled by default > >> GVT-g infrastructure > >> GuC command submission and fixes > >> BXT workarounds > >> SKL/BKL workarounds > >> Demidlayering device registration > >> Thundering herd fixes > >> Missing pci ids > >> Atomic updates > > > > Hmm. I did the merge and pushed it out, but testing it on my laptop > > shows some very annoying flickering problem. > > > > The screen goes dark for a very short while (one frame? Who knows? > > Seems longer occasionally). I have no idea what triggers it, but it > > happens quite a lot when it happens. Like once every second or two. > > And it seems to happen most of the time, although right now it happens > > to be behaving nicely, so sometimes it goes for a while without the > > flickering. > > > > Things *work*, but the flickering is nasty enough to make the end > > result painful to use. > > > > The only thing I see in dmesg that looks bad is > > > > [drm:intel_set_cpu_fifo_underrun_reporting [i915]] *ERROR* > > uncleared fifo underrun on pipe A > > [drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe A > > FIFO underrun > > > > but I've seen that before, and it happens a couple of times during > > boot. Not once per second. > > > > This is my old Vaio 11 Pro, now running Fedora 24 (up-to-date as of today). > > > > So it's bog-standard intel graphics (i5-4200U - Haswell ULT). > > > > Suggestions to try? > > psr or fbc are the likely culprits. More likely fbc if the underruns > correlate with the flicker (but note that by default we only report > them once per modest, needs to be reset with a dpms or > suspend/resume). Driver should even pick up the new module option > settings at runtime (but again you need to force a modeset, just > suspend/resume quickly), so fast to test. I think FBC is still disabled by default on HSW. So PSR seems more likely. The underruns might point at some watermark fail though :( I have a couple of pending PSR patches you may want to try as well, if i915.enable_psr=0 helps. First set is here: git://github.com/vsyrjala/linux.git psr_setup_time_2 This should be perfectly safe to go in actually, as it will only result in disabling PSR with certain panels. The second set is here: git://github.com/vsyrjala/linux.git psr_fixes_2 This one I think is causing some kind of slight regression on one machine in our CI system. Still not sure what's going on there. -- Ville Syrjälä Intel OTC