From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com Sender: Ingo Molnar Date: Tue, 2 Aug 2016 10:14:56 +0200 From: Ingo Molnar Message-ID: <20160802081438.GE9601@gmail.com> References: <1469635196-122447-1-git-send-email-thgarnie@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [kernel-hardening] Re: [PATCH] x86/mm: Enable KASLR for vmemmap memory region (x86_64) To: Thomas Garnier Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Kees Cook , x86@kernel.org, LKML , kernel-hardening@lists.openwall.com List-ID: * Thomas Garnier wrote: > On Wed, Jul 27, 2016 at 8:59 AM, Thomas Garnier wrote: > > Add vmemmap in the list of randomized memory regions. > > > > The vmemmap region holds a representation of the physical memory (through > > a struct page array). An attacker could use this region to disclose the > > kernel memory layout (walking the page linked list). > > > > Signed-off-by: Thomas Garnier > > Signed-off-by: Kees Cook > > --- > > Missing patch didn't pick-up by the tip bot on KASLR memory randomization. > > Resending after rebase on tip and tests as discussed with Ingo. > > Based on tip 4bcc8cf6ab5932cbb2511c8e18065e61b069f21c > > Ingo: Any comment? Can you integrate it on tip? > > > --- > > arch/x86/include/asm/kaslr.h | 1 + > > arch/x86/include/asm/pgtable_64_types.h | 4 +++- > > arch/x86/mm/kaslr.c | 24 +++++++++++++++++++++++- > > 3 files changed, 27 insertions(+), 2 deletions(-) After the merge window is over. There's no bad effect from the lack of this patch, other than lower level of randomization of kernel virtual addresses, right? Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932084AbcHBIPW (ORCPT ); Tue, 2 Aug 2016 04:15:22 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36390 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755746AbcHBIPN (ORCPT ); Tue, 2 Aug 2016 04:15:13 -0400 Date: Tue, 2 Aug 2016 10:14:56 +0200 From: Ingo Molnar To: Thomas Garnier Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Kees Cook , x86@kernel.org, LKML , kernel-hardening@lists.openwall.com Subject: Re: [PATCH] x86/mm: Enable KASLR for vmemmap memory region (x86_64) Message-ID: <20160802081438.GE9601@gmail.com> References: <1469635196-122447-1-git-send-email-thgarnie@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Thomas Garnier wrote: > On Wed, Jul 27, 2016 at 8:59 AM, Thomas Garnier wrote: > > Add vmemmap in the list of randomized memory regions. > > > > The vmemmap region holds a representation of the physical memory (through > > a struct page array). An attacker could use this region to disclose the > > kernel memory layout (walking the page linked list). > > > > Signed-off-by: Thomas Garnier > > Signed-off-by: Kees Cook > > --- > > Missing patch didn't pick-up by the tip bot on KASLR memory randomization. > > Resending after rebase on tip and tests as discussed with Ingo. > > Based on tip 4bcc8cf6ab5932cbb2511c8e18065e61b069f21c > > Ingo: Any comment? Can you integrate it on tip? > > > --- > > arch/x86/include/asm/kaslr.h | 1 + > > arch/x86/include/asm/pgtable_64_types.h | 4 +++- > > arch/x86/mm/kaslr.c | 24 +++++++++++++++++++++++- > > 3 files changed, 27 insertions(+), 2 deletions(-) After the merge window is over. There's no bad effect from the lack of this patch, other than lower level of randomization of kernel virtual addresses, right? Thanks, Ingo