From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v3] libxl: memory size in kb requires 64 bit variable
Date: Tue, 2 Aug 2016 10:49:24 +0100 [thread overview]
Message-ID: <20160802094924.GU22419@citrix.com> (raw)
In-Reply-To: <1469712919-11481-1-git-send-email-jgross@suse.com>
On Thu, Jul 28, 2016 at 03:35:19PM +0200, Juergen Gross wrote:
> libxl_set_memory_target() and several other interface functions of
> libxl use a 32 bit sized parameter for a memory size value in kBytes.
> This limits the maximum size to be passed in such a parameter
> depending on signedness of the parameter to 2TB or 4TB.
>
> Correct this by using 64 bit types.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
[...]
> +static int libxl__memkb_64to32(libxl_ctx *ctx, int rc,
> + uint64_t val64, uint32_t *ptr32)
> +{
It's a bit unusual for an internal function to take ctx. But I think you
want to avoid code repetition in the compact functions.
I can live with this.
Acked-by: Wei Liu <wei.liu2@citrix.com>
And thanks Dario for reviewing.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-02 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 13:35 [PATCH v3] libxl: memory size in kb requires 64 bit variable Juergen Gross
2016-08-02 9:49 ` Wei Liu [this message]
2016-08-02 16:04 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802094924.GU22419@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.