All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Wei Liu <Wei.Liu2@citrix.com>,
	"George.Dunlap@eu.citrix.com" <George.Dunlap@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: Default controller type for USB devices
Date: Tue, 2 Aug 2016 11:21:27 +0100	[thread overview]
Message-ID: <20160802102127.GW22419@citrix.com> (raw)
In-Reply-To: <5c26b517-998f-76e2-b1a3-2e33c08c73f4@citrix.com>

On Fri, Jul 29, 2016 at 02:15:24PM +0100, George Dunlap wrote:
> On 29/07/16 14:00, Juergen Gross wrote:
> > When specifying no USB controller type for a usb device the default is
> > chosen in libxl__device_usbctrl_setdefault(). For a HVM guest this is
> > currently the not yet supported "LIBXL_USBCTRL_TYPE_DEVICEMODEL".
> > 
> > Wouldn't it make sense to handle HVM guests in the same way as PV guests
> > as long as emulated USB devices are not implemented in libxl? Or would
> > this create future incompatibilities which we don't want to run into?
> > 
> > I'd be happy to send a patch if this is the way to go.
> 
> I think the big thing is that we can pretty much expect a typical HVM
> guest OS to have drivers for the emulated hardware; we *cannot* expect
> an average HVM guest OS to have pvfront drivers.  This will probably
> always apply to Windows, but at the moment it even applies to Linux.
> 
> So what happens right now if a user simply asks for a usbctrl for an HVM
> guest?  They get an error on domain creation.  This will hopefully
> prompt them to look into either switching back to the old format, or
> finding out about pvusb, at which point they can maybe find a pvusbfront
> for their OS.
> 
> If we make the switch you propose, then the user will create a usb
> controller, which will succeed; but if the guest OS doesn't have
> pvusbfront drivers (which is likely), then they will mysteriously just
> not see the controller and devices they've plugged in.
> 
> As a user, I would personally rather have an error message up front
> which gives me a clue as to what's wrong, rather than have things
> mysteriously not work and spend a lot of time going around trying to
> figure out what's wrong.
> 
> So I think the current default is the best.  Wei / Ian, any thoughts?
> 

Note that I haven't been following closely the HVM/PV USB development,
but I think your analysis makes sense.

Wei.

>  -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2016-08-02 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-29 13:00 Default controller type for USB devices Juergen Gross
2016-07-29 13:15 ` George Dunlap
2016-08-02 10:21   ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802102127.GW22419@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jgross@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.