From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
stable@vger.kernel.org, antoine.blangy@c-s.fr
Subject: Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()
Date: Tue, 2 Aug 2016 07:51:04 -0500 [thread overview]
Message-ID: <20160802125104.GA13214@gate.crashing.org> (raw)
In-Reply-To: <20160802080705.69A9F1A2394@localhost.localdomain>
On Tue, Aug 02, 2016 at 10:07:05AM +0200, Christophe Leroy wrote:
> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()") introduced a bug when destination
> address is odd and initial csum is not null
>
> In that (rare) case the initial csum value has to be rotated one byte
> as well as the resulting value is
>
> This patch also fixes related comments
>
> Fixes: 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()")
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> v2: updated comments as suggested by Segher
This looks good to me now, thanks,
Segher
next prev parent reply other threads:[~2016-08-02 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 8:07 [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Christophe Leroy
2016-08-02 12:41 ` Segher Boessenkool
2016-08-02 12:51 ` Segher Boessenkool [this message]
2016-08-04 3:53 ` Scott Wood
2016-08-04 6:15 ` Alessio Igor Bogani
2016-08-05 6:57 ` Michael Ellerman
2016-08-05 7:26 ` Christophe Leroy
2016-08-05 7:26 ` Christophe Leroy
2016-08-05 9:38 ` Michael Ellerman
2016-08-05 9:38 ` Michael Ellerman
2016-08-10 12:46 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802125104.GA13214@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=antoine.blangy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.