From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [Intel-gfx] [PATCH 0197/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 16:27:23 +0200 Message-ID: <20160802142723.GA3978@wunner.de> References: <20160802104847.26886-1-baolex.ni@intel.com> <20160802113737.GT4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout1.hostsharing.net (mailout1.hostsharing.net [83.223.95.204]) by gabe.freedesktop.org (Postfix) with ESMTPS id 088B56E5D4 for ; Tue, 2 Aug 2016 14:26:58 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160802113737.GT4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: wuninsu@gmail.com, k.kozlowski@samsung.com, chuansheng.liu@intel.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Baole Ni , kyungmin.park@samsung.com, kgene@kernel.org, bp@alien8.de, dougthompson@xmission.com, daniel.vetter@intel.com, treding@nvidia.com List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMDIsIDIwMTYgYXQgMDI6Mzc6MzdQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgQXVnIDAyLCAyMDE2IGF0IDA2OjQ4OjQ3UE0gKzA4MDAsIEJhb2xl IE5pIHdyb3RlOgo+ID4gSSBmaW5kIHRoYXQgdGhlIGRldmVsb3BlcnMgb2Z0ZW4ganVzdCBzcGVj aWZpZWQgdGhlIG51bWVyaWMgdmFsdWUKPiA+IHdoZW4gY2FsbGluZyBhIG1hY3JvIHdoaWNoIGlz IGRlZmluZWQgd2l0aCBhIHBhcmFtZXRlciBmb3IgYWNjZXNzIHBlcm1pc3Npb24uCj4gPiBBcyB3 ZSBrbm93LCB0aGVzZSBudW1lcmljIHZhbHVlIGZvciBhY2Nlc3MgcGVybWlzc2lvbiBoYXZlIGhh ZCB0aGUgY29ycmVzcG9uZGluZyBtYWNybywKPiA+IGFuZCB0aGF0IHVzaW5nIG1hY3JvIGNhbiBp bXByb3ZlIHRoZSByb2J1c3RuZXNzIGFuZCByZWFkYWJpbGl0eSBvZiB0aGUgY29kZSwKPiA+IHRo dXMsIEkgc3VnZ2VzdCByZXBsYWNpbmcgdGhlIG51bWVyaWMgcGFyYW1ldGVyIHdpdGggdGhlIG1h Y3JvLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaHVhbnNoZW5nIExpdSA8Y2h1YW5zaGVuZy5s aXVAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogQmFvbGUgTmkgPGJhb2xleC5uaUBpbnRl bC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5jIHwg NjQgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hh bmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9wYXJhbXMuYwo+ID4gaW5kZXggMTc3OWYwMi4uNzE4NGUwNiAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmMKPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmMKPiA+IEBAIC02MCwyMiArNjAsMjIgQEAgc3Ry dWN0IGk5MTVfcGFyYW1zIGk5MTUgX19yZWFkX21vc3RseSA9IHsKPiA+ICAJLmluamVjdF9sb2Fk X2ZhaWx1cmUgPSAwLAo+ID4gIH07Cj4gPiAgCj4gPiAtbW9kdWxlX3BhcmFtX25hbWVkKG1vZGVz ZXQsIGk5MTUubW9kZXNldCwgaW50LCAwNDAwKTsKPiA+ICttb2R1bGVfcGFyYW1fbmFtZWQobW9k ZXNldCwgaTkxNS5tb2Rlc2V0LCBpbnQsIFNfSVJVU1IpOwo+IAo+IEF0IGxlYXN0IEkgY2FuJ3Qg cmVhZCB0aG9zZSBtYWNyb3MuIE9jdGFsIGlzIG11Y2ggY2xlYXJlciBJTU8uCgpJdCdzIGFsc28g ZWFzaWVyIHRvIGdyZXAgZm9yLCBzYXksIDY0NCwgcmF0aGVyIHRoYW4gZm9ybXVsYXRpbmcgYQpy ZWdleCB3aXRoIGFsbCBwb3NzaWJsZSBvcmRlcmluZyBwZXJtdXRhdGlvbnMgb2YgdGhlc2UgbWFj cm9zLgoKQmVzdCByZWdhcmRzLAoKTHVrYXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756847AbcHBOhz (ORCPT ); Tue, 2 Aug 2016 10:37:55 -0400 Received: from mailout1.hostsharing.net ([83.223.95.204]:39649 "EHLO mailout1.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965453AbcHBOhM (ORCPT ); Tue, 2 Aug 2016 10:37:12 -0400 Date: Tue, 2 Aug 2016 16:27:23 +0200 From: Lukas Wunner To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Baole Ni , wuninsu@gmail.com, k.kozlowski@samsung.com, treding@nvidia.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kgene@kernel.org, bp@alien8.de, dri-devel@lists.freedesktop.org, dougthompson@xmission.com, daniel.vetter@intel.com, chuansheng.liu@intel.com Subject: Re: [Intel-gfx] [PATCH 0197/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802142723.GA3978@wunner.de> References: <20160802104847.26886-1-baolex.ni@intel.com> <20160802113737.GT4329@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160802113737.GT4329@intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 02:37:37PM +0300, Ville Syrjälä wrote: > On Tue, Aug 02, 2016 at 06:48:47PM +0800, Baole Ni wrote: > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access permission. > > As we know, these numeric value for access permission have had the corresponding macro, > > and that using macro can improve the robustness and readability of the code, > > thus, I suggest replacing the numeric parameter with the macro. > > > > Signed-off-by: Chuansheng Liu > > Signed-off-by: Baole Ni > > --- > > drivers/gpu/drm/i915/i915_params.c | 64 +++++++++++++++++++------------------- > > 1 file changed, 32 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > > index 1779f02..7184e06 100644 > > --- a/drivers/gpu/drm/i915/i915_params.c > > +++ b/drivers/gpu/drm/i915/i915_params.c > > @@ -60,22 +60,22 @@ struct i915_params i915 __read_mostly = { > > .inject_load_failure = 0, > > }; > > > > -module_param_named(modeset, i915.modeset, int, 0400); > > +module_param_named(modeset, i915.modeset, int, S_IRUSR); > > At least I can't read those macros. Octal is much clearer IMO. It's also easier to grep for, say, 644, rather than formulating a regex with all possible ordering permutations of these macros. Best regards, Lukas