From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: Fix build failture on perl script context
Date: Tue, 2 Aug 2016 12:10:01 -0300 [thread overview]
Message-ID: <20160802151001.GA16017@kernel.org> (raw)
In-Reply-To: <20160802141232.GB9647@kernel.org>
Em Tue, Aug 02, 2016 at 11:12:32AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Aug 02, 2016 at 11:03:02PM +0900, Namhyung Kim escreveu:
> > What I did to fix is adding '-Wno-shadow' as the error message said
> > it's the cause of the failure. Since it's from the perl (not perf)
> > code base, we don't have the control so I just wanted to ignore the
> > warning when compiling perl scripting code.
> >
> > Is it ok for you?
>
> Now it is :-)
>
> I'll stick this to the changeset log as the reason for adding
> -wno-shadow just for building the perl code.
>
> Sometimes we'll get to this conclusion after some thinking, if you add
> these explanations to the changelog then it speeds up reviewing.
Cool, this fixed the build as well for fedora rawhide.
- Arnaldo
next prev parent reply other threads:[~2016-08-02 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 2:43 [PATCH] perf tools: Fix build failture on perl script context Namhyung Kim
2016-08-02 13:26 ` Arnaldo Carvalho de Melo
2016-08-02 13:29 ` Arnaldo Carvalho de Melo
2016-08-02 14:03 ` Namhyung Kim
2016-08-02 14:12 ` Arnaldo Carvalho de Melo
2016-08-02 15:10 ` Arnaldo Carvalho de Melo [this message]
2016-08-04 9:10 ` [tip:perf/urgent] perf tools: Fix build failure " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802151001.GA16017@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.