From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Tue, 2 Aug 2016 11:57:25 -0400 Subject: [PATCH 0812/1285] Replace numeric parameter like 0444 with macro In-Reply-To: <3d93cf14-6171-b4b7-f204-6b1148e5849f@grimberg.me> References: <20160802114854.4100-1-baolex.ni@intel.com> <3d93cf14-6171-b4b7-f204-6b1148e5849f@grimberg.me> Message-ID: <20160802155725.GA6066@home.goodmis.org> On Tue, Aug 02, 2016@04:29:53PM +0300, Sagi Grimberg wrote: > I assume that you didn't try to send a 1285 patches set :) No he actually did. And some of us were unfortunate enough to be Cc'd on a hundred of them. > > I think you can safely squash the two patches together. I've NAKed all patches I was Cc'd on. IMNSHO the change makes it less readable and more error prone. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935085AbcHBP5n (ORCPT ); Tue, 2 Aug 2016 11:57:43 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:12522 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964781AbcHBP52 (ORCPT ); Tue, 2 Aug 2016 11:57:28 -0400 Date: Tue, 2 Aug 2016 11:57:25 -0400 From: Steven Rostedt To: Sagi Grimberg Cc: Baole Ni , keith.busch@intel.com, axboe@fb.com, Allen.Hubbe@emc.com, rjui@broadcom.com, sbranden@broadcom.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, chuansheng.liu@intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 0812/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802155725.GA6066@home.goodmis.org> References: <20160802114854.4100-1-baolex.ni@intel.com> <3d93cf14-6171-b4b7-f204-6b1148e5849f@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d93cf14-6171-b4b7-f204-6b1148e5849f@grimberg.me> User-Agent: Mutt/1.6.0 (2016-04-01) X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 04:29:53PM +0300, Sagi Grimberg wrote: > I assume that you didn't try to send a 1285 patches set :) No he actually did. And some of us were unfortunate enough to be Cc'd on a hundred of them. > > I think you can safely squash the two patches together. I've NAKed all patches I was Cc'd on. IMNSHO the change makes it less readable and more error prone. -- Steve