From: Segher Boessenkool <segher@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: Baole Ni <baolex.ni@intel.com>,
chuansheng.liu@intel.com, maurochehab@gmail.com,
mchehab@redhat.com, linux-edac@vger.kernel.org,
lee.jones@linaro.org, linux-kernel@vger.kernel.org,
mchehab@infradead.org, egor@pasemi.com,
dougthompson@xmission.com, bp@alien8.de, mchehab@kernel.org,
linuxppc-dev@lists.ozlabs.org, m.chehab@samsung.com
Subject: Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 14:11:30 -0500 [thread overview]
Message-ID: <20160802191130.GG9387@gate.crashing.org> (raw)
In-Reply-To: <20160802185447.GA5288@localhost>
On Tue, Aug 02, 2016 at 11:54:47AM -0700, Olof Johansson wrote:
> On Tue, Aug 02, 2016 at 06:45:15PM +0800, Baole Ni wrote:
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
>
> Am I the only one who find the readability to be MUCH better for the
> numeric values?
You are not the only one. Robustness is a non-issue here as well (except
that this patch series showed that some mail servers struggle to handle
1285 emails).
Segher
prev parent reply other threads:[~2016-08-02 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:45 [PATCH 0157/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 18:54 ` Olof Johansson
2016-08-02 19:11 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802191130.GG9387@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=baolex.ni@intel.com \
--cc=bp@alien8.de \
--cc=chuansheng.liu@intel.com \
--cc=dougthompson@xmission.com \
--cc=egor@pasemi.com \
--cc=lee.jones@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.chehab@samsung.com \
--cc=maurochehab@gmail.com \
--cc=mchehab@infradead.org \
--cc=mchehab@kernel.org \
--cc=mchehab@redhat.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.