From: Dave Chinner <david@fromorbit.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: fstests@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] check: allow comments in exclude files
Date: Wed, 3 Aug 2016 09:20:04 +1000 [thread overview]
Message-ID: <20160802232004.GP12670@dastard> (raw)
In-Reply-To: <a860d00b5fdc3d88b0ce692585d0046e259c71c4.1470001873.git.osandov@fb.com>
On Sun, Jul 31, 2016 at 02:53:44PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Sometimes it's useful to keep track of why we're excluding a particular
> test. Technically, we can include whatever explanation we want in the
> exclude file since we just grep for the test names, but properly
> supporting comments is a little more robust. This patch makes it so that
> the rest of a line after a '#' is ignored.
>
> Signed-off-by: Omar Sandoval <osandov@fb.com>
seems reasonable to me.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-08-02 23:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 21:53 [PATCH] check: allow comments in exclude files Omar Sandoval
2016-08-02 23:20 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802232004.GP12670@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.