From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 03 Aug 2016 07:57:08 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:53356 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23991859AbcHCF5BDXxGp (ORCPT ); Wed, 3 Aug 2016 07:57:01 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.15.2/8.14.8) with ESMTP id u735uuNu014778; Wed, 3 Aug 2016 07:56:56 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.15.2/8.15.2/Submit) id u735urBB014777; Wed, 3 Aug 2016 07:56:53 +0200 Date: Wed, 3 Aug 2016 07:56:53 +0200 From: Ralf Baechle To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Jon Hunter , Kevin Hilman , Marc Zyngier , John Crispin , Thomas Gleixner , linux-mips@linux-mips.org, Sudip Mukherjee Subject: Re: [PATCH] mips: lantiq: fix irq_chip name to not land in new parent field Message-ID: <20160803055653.GG15910@linux-mips.org> References: <20160802185447.3831-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802185447.3831-1-paul.gortmaker@windriver.com> User-Agent: Mutt/1.6.2 (2016-07-01) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 54400 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Aug 02, 2016 at 02:54:47PM -0400, Paul Gortmaker wrote: > As of commit be45beb2df69 ("genirq: Add runtime power management > support for IRQ chips") the irq_chip struct got a struct *device > parent_device field added to it. However, it was added at the > beginning of the struct, which previously was the "name" entry. > > The driver here was using a mix of ordered struct init entries and > named init entries. It was supplying the name assuming it was the 1st > in the order, and hence when that became a struct *device we get: > > arch/mips/lantiq/irq.c:209:2: warning: initialization from incompatible pointer type [enabled by default] > arch/mips/lantiq/irq.c:209:2: warning: (near initialization for 'ltq_irq_type.parent_device') [enabled by default] > arch/mips/lantiq/irq.c:219:2: warning: initialization from incompatible pointer type [enabled by default] > arch/mips/lantiq/irq.c:219:2: warning: (near initialization for 'ltq_eiu_type.parent_device') [enabled by default] > > While not runtime tested, I can't imagine trying to dereference a > a struct device field from a char string will end well. > > Here we've used named element init entries for the name string as well > to fix it. > > Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips") > Cc: Jon Hunter > Cc: Kevin Hilman > Cc: Marc Zyngier > Cc: John Crispin > Cc: Ralf Baechle > Cc: Thomas Gleixner > Cc: linux-mips@linux-mips.org > Signed-off-by: Paul Gortmaker Thanks for the patch but I've already applied the identical patch https://patchwork.linux-mips.org/patch/13684/. Ralf