From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] qed: Revisit chain implementation
Date: Wed, 03 Aug 2016 08:49:49 +0000 [thread overview]
Message-ID: <20160803084949.GA2154@mwanda> (raw)
Hello Yuval Mintz,
The patch a91eb52abb50: "qed: Revisit chain implementation" from Jun
3, 2016, leads to the following static checker warning:
include/linux/qed/qed_chain.h:404 qed_chain_consume()
warn: inconsistent indenting
include/linux/qed/qed_chain.h
386 static inline void *qed_chain_consume(struct qed_chain *p_chain)
387 {
388 void *p_ret = NULL, *p_cons_idx, *p_cons_page_idx;
389
390 if (is_chain_u16(p_chain)) {
391 if ((p_chain->u.chain16.cons_idx &
392 p_chain->elem_per_page_mask) = p_chain->next_page_mask) {
393 p_cons_idx = &p_chain->u.chain16.cons_idx;
394 p_cons_page_idx = &p_chain->pbl.u.pbl16.cons_page_idx;
395 qed_chain_advance_page(p_chain, &p_chain->p_cons_elem,
396 p_cons_idx, p_cons_page_idx);
397 }
398 p_chain->u.chain16.cons_idx++;
399 } else {
400 if ((p_chain->u.chain32.cons_idx &
401 p_chain->elem_per_page_mask) = p_chain->next_page_mask) {
402 p_cons_idx = &p_chain->u.chain32.cons_idx;
403 p_cons_page_idx = &p_chain->pbl.u.pbl32.cons_page_idx;
404 qed_chain_advance_page(p_chain, &p_chain->p_cons_elem,
^^^^^^^^^^^^^^^^^^^^^^
Add a tab?
405 p_cons_idx, p_cons_page_idx);
406 }
407 p_chain->u.chain32.cons_idx++;
408 }
409
410 p_ret = p_chain->p_cons_elem;
411 p_chain->p_cons_elem = (void *)(((u8 *)p_chain->p_cons_elem) +
412 p_chain->elem_size);
413
414 return p_ret;
415 }
regards,
dan carpenter
reply other threads:[~2016-08-03 8:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803084949.GA2154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.