From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:52309 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753044AbcHCNif (ORCPT
	<rfc822;stable@vger.kernel.org>); Wed, 3 Aug 2016 09:38:35 -0400
Date: Wed, 3 Aug 2016 15:28:10 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Eric Schultz <eric@startuperic.com>
Cc: stable@vger.kernel.org
Subject: Re: 4.4.16: ovl: BUG() in notify_change()
Message-ID: <20160803132810.GA31939@kroah.com>
References: <5896D6A2-5595-4938-A189-F58BA6FA6E75@startuperic.com>
 <20160803054536.GC6711@kroah.com>
 <5433B9A5-43D8-4EA8-AEFC-E7D705548944@startuperic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5433B9A5-43D8-4EA8-AEFC-E7D705548944@startuperic.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Aug 03, 2016 at 05:02:41AM -0500, Eric Schultz wrote:
> 
> > On Aug 3, 2016, at 12:45 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Sat, Jul 30, 2016 at 10:28:16AM -0500, Eric Schultz wrote:
> >> Hey Greg,
> >> 
> >> Apologies in advance if this isn’t the correct method or channel to report bugs
> >> with kernel 4.4.16.
> >> 
> >> Commit c12dada5f28a4894b81df2666c060f5cecc02cf9 was included in kernel 4.4.16
> >> but relies on its parent upstream commit 
> >> b99c2d913810e56682a538c9f2394d76fca808f8, currently missing from
> >> 4.4.16, otherwise BUG() is thrown for certain operations in overlayfs (I’m able
> >> to reproduce the issue).  I can confirm porting upstream commit 
> >> b99c2d913810e56682a538c9f2394d76fca808f8 in to kernel 4.4.16 solves the issues.
> >> Please let me know if I could help out in any other way.
> > 
> > This patch does not apply to the 4.4.y stable tree, can you provide a
> > backport?
> > 
> > thanks,
> > 
> > greg k-h
> 
> No problem, attached is a appliable patch for 4.4.y and was taken 
> from https://bugzilla.kernel.org/show_bug.cgi?id=150711
> 
> 
> --- a/fs/overlayfs/inode.c	2016-07-31 15:41:55.613057608 +0200
> +++ a/fs/overlayfs/inode.c	2016-07-31 15:46:24.498060788 +0200
> @@ -63,6 +63,9 @@ 
>  	if (!err) {
>  		upperdentry = ovl_dentry_upper(dentry);
>  
> +		if (attr->ia_valid & (ATTR_KILL_SUID|ATTR_KILL_SGID))
> +			attr->ia_valid &= ~ATTR_MODE;
> +
>  		mutex_lock(&upperdentry->d_inode->i_mutex);
>  		err = notify_change(upperdentry, attr, NULL);
>  		if (!err)

Thanks, that worked!

greg k-h