All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alban Bedel <alban.bedel@avionic-design.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra: config: Add 'pci enum' to preboot when PCI is enabled
Date: Thu, 4 Aug 2016 11:05:00 +0200	[thread overview]
Message-ID: <20160804110500.4734057c@avionic-0020> (raw)
In-Reply-To: <CAPnjgZ3oBA5r0sg8BnYguXyDXSdtAhQbcxXhCNkLKi=fygKPdw@mail.gmail.com>

On Wed, 3 Aug 2016 19:16:57 -0600
Simon Glass <sjg@chromium.org> wrote:

> Hi,
> 
> On 3 August 2016 at 09:37, Stephen Warren <swarren@wwwdotorg.org> wrote:
> > On 08/03/2016 03:35 AM, Alban Bedel wrote:
> >>
> >> For simplicity and backward compatibility automatically run 'pci enum'
> >> via preboot when PCI is enabled. As preboot is already used for the
> >> USB keyboard support this rework how CONFIG_PREBOOT is set to allow
> >> combining several commands.
> >
> >
> > For better or worse, this was a deliberate change, so I don't think this
> > patch will be accepted.
> >
> > If it is, then you should apply it to all boards, not just Tegra boards, and
> > adjust include/config_distro_bootcmd.h since it will no longer need to run
> > "pci enum", and also test/py/tests/test_net.py won't need to either.
> 
> The boards which need PCI to boot are still few... we've talked about
> this before. It would be great if we could find a way to detect or be
> told that boot devices are on PCI and probe it accordingly. Perhaps we
> should have a driver flag?

In my case I needed this for network boot. However I just found out
that with a properly reseted environment this is already handled, so
this is not needed. Sorry for the noise.

Alban

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160804/f69c42d5/attachment.sig>

      reply	other threads:[~2016-08-04  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03  9:35 [U-Boot] [PATCH] tegra: config: Add 'pci enum' to preboot when PCI is enabled Alban Bedel
2016-08-03 15:37 ` Stephen Warren
2016-08-04  1:16   ` Simon Glass
2016-08-04  9:05     ` Alban Bedel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160804110500.4734057c@avionic-0020 \
    --to=alban.bedel@avionic-design.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.