From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: "Michel Dänzer" <michel@daenzer.net>,
amd-gfx@lists.freedesktop.org,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 0/6] drm: Explicit target vblank seqno for page flips
Date: Thu, 4 Aug 2016 14:15:25 +0300 [thread overview]
Message-ID: <20160804111525.GE4329@intel.com> (raw)
In-Reply-To: <CAPj87rPO-QbyhmBy2p3XASqNdzrm3hmw0EsLLJYB2K4bBvTTrw@mail.gmail.com>
On Thu, Aug 04, 2016 at 11:12:27AM +0100, Daniel Stone wrote:
> On 4 August 2016 at 11:01, Michel Dänzer <michel@daenzer.net> wrote:
> > On 04.08.2016 18:51, Daniel Stone wrote:
> >> On 4 August 2016 at 04:39, Michel Dänzer <michel@daenzer.net> wrote:
> >>> Patch 6 extends the ioctl with new flags, which allow userspace to
> >>> explicitly specify the target vblank seqno. This can also avoid delaying
> >>> flips in some cases where we are already in the target vertical blank
> >>> period when the ioctl is called.
> >>
> >> Is there open userspace for this?
> >
> > Sure, referenced in patch 6:
> >
> > https://cgit.freedesktop.org/~daenzer/xf86-video-ati/commit/?id=fc884a8af25345c32bd4104c864ecfeb9bb3db9b
> >
> > https://cgit.freedesktop.org/~daenzer/xf86-video-amdgpu/commit/?id=b8631a9ba49c0d0ebe5dcd1dbfb68fcfe907296f
> >
> >
> >> What's the behaviour vs. modeset: does the modeset request block until
> >> the last-requested flip is complete? If so, is there some kind of upper
> >> bound on the number of blank periods to wait for?
> >
> > Did you read the patch? :)
>
> Nope, for some reason my mailer decided it didn't like it, but I did
> find it in the archives.
>
> > The only change compared to the existing ioctl is that userspace can ask
> > for a flip to take effect in the current vblank seqno. The code added by
> > the patch checks for target vblank seqno > current vblank seqno + 1 and
> > returns -EINVAL in that case. This is also documented in drm_mode.h.
>
> Is there any particular benefit to having split absolute/relative
> modes in this case? Personally I'm struggling to see the use of
> relative.
Last time I read the egl spec it specified swap interval as
RELATIVE=<interval>, whereas GLX_whatever specified the more sensible
ABSOLUTE=<last+interval> behaviour.
I suppose that means Mesa is technically not egl compliant with DRI2/3.
>
> >> Is all this tested somewhere?
> >
> > Yes, I've been using it for a while on all my machines.
>
> I mean in a test suite. :)
>
> Cheers,
> Daniel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-04 11:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 3:39 [PATCH 0/6] drm: Explicit target vblank seqno for page flips Michel Dänzer
[not found] ` <1470281981-18172-1-git-send-email-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2016-08-04 3:39 ` [PATCH 1/6] drm: Add page_flip_target CRTC hook Michel Dänzer
2016-08-04 10:47 ` Daniel Vetter
2016-08-04 11:01 ` Daniel Vetter
[not found] ` <20160804110116.GI6232-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2016-08-08 3:54 ` Michel Dänzer
2016-08-08 8:14 ` Daniel Vetter
[not found] ` <1470281981-18172-2-git-send-email-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2016-08-04 15:13 ` Alex Deucher
[not found] ` <CADnq5_OeoXDYnjAwnQCY9RXwqMo8eQ8LqWgUOeC0tgjH1b6M_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-08 3:33 ` Michel Dänzer
2016-08-08 7:23 ` [PATCH 1/6] drm: Add page_flip_target CRTC hook v2 Michel Dänzer
2016-08-04 3:39 ` [PATCH 2/6] drm/amdgpu: Provide page_flip_target hook Michel Dänzer
2016-08-04 3:39 ` [PATCH 4/6] drm/radeon: " Michel Dänzer
2016-08-16 0:35 ` Mario Kleiner
[not found] ` <dccd9347-afc4-83a6-8014-20692e71fd03-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-16 1:49 ` Michel Dänzer
2016-09-17 12:41 ` Mario Kleiner
[not found] ` <b00edbdc-c467-3f33-5a07-32def2961190-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-20 2:59 ` Michel Dänzer
2016-08-04 3:39 ` [PATCH 5/6] drm/radeon: Set MASTER_UPDATE_MODE to 0 again Michel Dänzer
2016-08-04 3:39 ` [PATCH 6/6] drm: Add DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE/RELATIVE flags Michel Dänzer
2016-08-04 7:42 ` Ville Syrjälä
[not found] ` <20160804074205.GY4329-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-08 7:06 ` Michel Dänzer
2016-08-04 10:56 ` Daniel Vetter
[not found] ` <20160804105609.GG6232-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2016-08-08 6:53 ` Michel Dänzer
2016-08-08 7:23 ` [PATCH 6/6] drm: Add DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE/RELATIVE flags v2 Michel Dänzer
2016-08-16 1:32 ` Mario Kleiner
[not found] ` <8974b919-6f9c-5912-0d26-f1a526829f83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-16 1:46 ` Michel Dänzer
2016-09-08 9:36 ` Pekka Paalanen
2016-08-04 7:38 ` [PATCH 0/6] drm: Explicit target vblank seqno for page flips Christian König
2016-08-04 3:39 ` [PATCH 3/6] drm/amdgpu: Set MASTER_UPDATE_MODE to 0 again Michel Dänzer
2016-08-04 9:51 ` [PATCH 0/6] drm: Explicit target vblank seqno for page flips Daniel Stone
2016-08-04 10:01 ` Michel Dänzer
2016-08-04 10:12 ` Daniel Stone
2016-08-04 11:15 ` Ville Syrjälä [this message]
[not found] ` <CAPj87rPO-QbyhmBy2p3XASqNdzrm3hmw0EsLLJYB2K4bBvTTrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-08 3:53 ` Michel Dänzer
2016-08-04 15:16 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804111525.GE4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.