Re: [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Aug 04, 2016 at 12:52:26PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build"):
> > Clone, build and package XTF for later use.
> ...
> > diff --git a/ts-xtf-build b/ts-xtf-build
> > new file mode 100755
> > index 0000000..5c4c3ec
> > --- /dev/null
> > +++ b/ts-xtf-build
> ...
> > +selectbuildhost(\@ARGV);
> > +# remaining arguments are passed as targets to "make"
> 
> This doesn't seem to be actually true.
> 

Right, I will delete this.

> > +    target_cmd_build($ho, 300, $builddir, <<END);
> > +        cd xtf
> > +        rm -f ../xtf-build-ok-stamp
> > +        ( make xtfdir=$xtfdir 2>&1 && touch ../xtf-build-ok-stamp
> > +        ) |tee ../xtf-build-log
> > +        test -f ../xtf-build-ok-stamp
> 
> I think you should lift buildcmd_stamped_logged out of ts-xen-build.
> 

NP.

> > +#/;
> 
> These are for the benefit of some editor's indenting ?
> 

Yes. I think so. Copied and pasted from ts-xen-build, actually.


> > +sub stash () {
> > +    built_stash($ho, $builddir, "xtfdist", "xtfdist");
> > +}
> 
> Can you post a tar zvvtf of a sample xtfdist tarball ?

drwxr-xr-x osstest/osstest   0 2016-08-04 08:30 home/
drwxr-xr-x osstest/osstest   0 2016-08-04 08:30 home/osstest/
drwxr-xr-x osstest/osstest   0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/
drwxr-xr-x osstest/osstest   0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/
-rwxr-xr-x osstest/osstest 20124 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/xtf-runner
drwxr-xr-x osstest/osstest     0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/
drwxr-xr-x osstest/osstest     0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-168/
-rwxr-xr-x osstest/osstest 1179952 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-168/test-hvm64-xsa-168
-rw-r--r-- osstest/osstest     563 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-168/test-hvm64-xsa-168.cfg
-rw-r--r-- osstest/osstest     116 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-168/info.json
drwxr-xr-x osstest/osstest       0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-173/
-rw-r--r-- osstest/osstest     528 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-173/test-hvm64-xsa-173.cfg

[repetitive output truncated]

> 
> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel