From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Disable stolen on 865G Date: Thu, 4 Aug 2016 19:44:14 +0300 Message-ID: <20160804164414.GI4329@intel.com> References: <1470304564-9842-1-git-send-email-chris@chris-wilson.co.uk> <20160804163121.GP6232@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 5538A6E9FA for ; Thu, 4 Aug 2016 16:44:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160804163121.GP6232@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBdWcgMDQsIDIwMTYgYXQgMDY6MzE6MjFQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIEF1ZyAwNCwgMjAxNiBhdCAxMDo1NjowNEFNICswMTAwLCBDaHJpcyBX aWxzb24gd3JvdGU6Cj4gPiBJdCBhcHBlYXJzIG91ciBjYWxjdWxhdGlvbiBmb3IgdGhlIGFkZHJl c3Mgb2Ygc3RvbGVuIG1lbW9yeSBpcyBpbmNvcnJlY3QKPiA+IGZvciA4NjVHLCBzbyBmb3IgdGhl IHRpbWUgYmVpbmcgZGlzYWJsZSBvdXIgdXNlIG9mIHRoYXQgbWVtb3J5Lgo+ID4gCj4gPiBCdWd6 aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY0NzMK PiA+IEZpeGVzOiAwYWQ5OGM3NGUwOTMgKCJkcm0vaTkxNTogRGVhdGVybWluZSB0aGUgc3RvbGVu IG1lbW9yeSBiYXNlIGFkZHJlc3MuLi4iKQo+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPgo+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiAKPiBBY2tl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KClRoZXJlJ3MgYSBw b3RlbnRpYWxseSBiZXR0ZXIgcGF0Y2ggKG9uZSB0aGF0IGFjdHVhbGx5IGZpeGVzIHRoZSBzdG9s ZW4KYmFzZSBjYWxjdWxhdGlvbikgYXR0YWNoZWQgdG8gdGhlIGJ1Zy4KCj4gPiAtLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zdG9sZW4uYyB8IDEgKwo+ID4gIDEgZmlsZSBj aGFuZ2VkLCAxIGluc2VydGlvbigrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fc3RvbGVuLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9zdG9sZW4uYwo+ID4gaW5kZXggZTE3OTFmZTk2Njc0Li44YjUwMWRkYmM3ODQgMTAwNjQ0Cj4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zdG9sZW4uYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc3RvbGVuLmMKPiA+IEBAIC0xMjIsNiArMTIy LDcgQEAgc3RhdGljIHVuc2lnbmVkIGxvbmcgaTkxNV9zdG9sZW5fdG9fcGh5c2ljYWwoc3RydWN0 IGRybV9kZXZpY2UgKmRldikKPiA+ICAJCSAqIGFsd2F5cyBhdCBUT1VEPyBJZS4gaXMgaXQgYWx3 YXlzIHRoZSBsYXN0Cj4gPiAgCQkgKiBvbmUgdG8gYmUgYWxsb2NhdGVkIGJ5IHRoZSBCSU9TPwo+ ID4gIAkJICovCj4gPiArCQlpZiAoMCkgLyogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTY0NzMgKi8KPiA+ICAJCXBjaV9idXNfcmVhZF9jb25maWdfd29yZChk ZXYtPnBkZXYtPmJ1cywgUENJX0RFVkZOKDAsIDApLAo+ID4gIAkJCQkJIEk4NjVfVE9VRCwgJnRv dWQpOwo+ID4gIAo+ID4gLS0gCj4gPiAyLjguMQo+ID4gCj4gCj4gLS0gCj4gRGFuaWVsIFZldHRl cgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZm d2xsLmNoCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:30693 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758844AbcHDQpj (ORCPT ); Thu, 4 Aug 2016 12:45:39 -0400 Date: Thu, 4 Aug 2016 19:44:14 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Daniel Vetter Cc: Chris Wilson , intel-gfx@lists.freedesktop.org, Daniel Vetter , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Disable stolen on 865G Message-ID: <20160804164414.GI4329@intel.com> References: <1470304564-9842-1-git-send-email-chris@chris-wilson.co.uk> <20160804163121.GP6232@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160804163121.GP6232@phenom.ffwll.local> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Aug 04, 2016 at 06:31:21PM +0200, Daniel Vetter wrote: > On Thu, Aug 04, 2016 at 10:56:04AM +0100, Chris Wilson wrote: > > It appears our calculation for the address of stolen memory is incorrect > > for 865G, so for the time being disable our use of that memory. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473 > > Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...") > > Signed-off-by: Chris Wilson > > Cc: Ville Syrj�l� > > Cc: Daniel Vetter > > Cc: stable@vger.kernel.org > > Acked-by: Daniel Vetter There's a potentially better patch (one that actually fixes the stolen base calculation) attached to the bug. > > --- > > drivers/gpu/drm/i915/i915_gem_stolen.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c > > index e1791fe96674..8b501ddbc784 100644 > > --- a/drivers/gpu/drm/i915/i915_gem_stolen.c > > +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c > > @@ -122,6 +122,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev) > > * always at TOUD? Ie. is it always the last > > * one to be allocated by the BIOS? > > */ > > + if (0) /* https://bugs.freedesktop.org/show_bug.cgi?id=96473 */ > > pci_bus_read_config_word(dev->pdev->bus, PCI_DEVFN(0, 0), > > I865_TOUD, &toud); > > > > -- > > 2.8.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Ville Syrj�l� Intel OTC