From: Christoph Hellwig <hch@infradead.org>
To: Mike Christie <mchristi@redhat.com>
Cc: ross.zwisler@linux.intel.com, linux-ext4@vger.kernel.org,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
david@fromorbit.com, minchan@kernel.org, ngupta@vflare.org,
vishal.l.verma@intel.com, axboe@kernel.dk
Subject: Re: [PATCH 1/1] mm/block: convert rw_page users to bio op use
Date: Fri, 5 Aug 2016 00:57:56 -0700 [thread overview]
Message-ID: <20160805075756.GA28577@infradead.org> (raw)
In-Reply-To: <1470331056-796-1-git-send-email-mchristi@redhat.com>
>
> The rw_page users were not converted to use bio/req ops. As a result
> bdev_write_page is not passing down REQ_OP_WRITE and the IOs will
> be sent down as reads.
Can we just get rid of REQ_OP_WRITE enum for the ->rw_page interface
and pass a 'bool write'? If not I'd prefer to avoid using op_is_write
as much as possible - it's a confusing interface if we really want
to do a switch on read vs write vs invalid.
next prev parent reply other threads:[~2016-08-05 7:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 17:17 [PATCH 1/1] mm/block: convert rw_page users to bio op use Mike Christie
2016-08-04 17:50 ` kbuild test robot
2016-08-04 19:27 ` Jens Axboe
2016-08-04 19:59 ` Mike Christie
2016-08-04 20:15 ` Jens Axboe
2016-08-04 21:24 ` Mike Christie
2016-08-04 21:26 ` Jens Axboe
2016-08-05 2:18 ` Dave Chinner
2016-08-05 3:30 ` Mike Christie
2016-08-05 7:53 ` Christoph Hellwig
2016-08-04 18:46 ` Ross Zwisler
2016-08-04 18:51 ` Mike Christie
2016-08-05 7:57 ` Christoph Hellwig [this message]
2016-08-05 13:52 ` Jens Axboe
2016-08-05 14:09 ` Jens Axboe
2016-08-05 18:05 ` Mike Christie
2016-08-05 21:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805075756.GA28577@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=ross.zwisler@linux.intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.