From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] fix incorrect identify implementation in nvme
Date: Fri, 5 Aug 2016 10:54:21 +0200 [thread overview]
Message-ID: <20160805085421.GA5503@noname.redhat.com> (raw)
In-Reply-To: <87shuj7lt3.fsf@dusky.pond.sub.org>
Am 05.08.2016 um 08:48 hat Markus Armbruster geschrieben:
> Keith Busch <keith.busch@intel.com> writes:
>
> > On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote:
> >> Third resent of this series after this didn't get picked up the
> >> previous times. The Qemu NVMe implementation mistakes the cns
> >> field in the Identify command as a boolean. This was never
> >> true, and is actively harmful since NVMe1.1 (which the Qemu
> >> device claims to support) supports more than two Identify variants.
> >>
> >> We had to add a quirk in Linux to work around this behavior.
> >
> > Yes, these are great. Do we need to ping a maintainer to go through
> > their tree, or can this be applied immediately? If need be, I can apply
> > and send a pull request.
>
> $ scripts/get_maintainer.pl -f hw/block/nvme.c
> Keith Busch <keith.busch@intel.com> (supporter:nvme)
> Kevin Wolf <kwolf@redhat.com> (supporter:Block layer core)
> Max Reitz <mreitz@redhat.com> (supporter:Block layer core)
> qemu-block@nongnu.org (open list:nvme)
> qemu-devel@nongnu.org (open list:All patches CC here)
>
> Send a pull request (assuming you have a properly signed PGP key).
Keith, I'll take the patches through my tree with your Acked-by,
assuming that this makes the process easier for you.
Sorry for forgetting about the previous version, I had intended to give
others a chance to comment before I apply them, but then it fell through
the cracks. Next time someone just send a quick "ping" reply after a week
or so, please.
Kevin
prev parent reply other threads:[~2016-08-05 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 19:42 [Qemu-devel] fix incorrect identify implementation in nvme Christoph Hellwig
2016-08-04 19:42 ` [Qemu-devel] [PATCH 1/2] nvme: fix identify to be NVMe 1.1 compliant Christoph Hellwig
2016-08-04 19:42 ` [Qemu-devel] [PATCH 2/2] nvme: bump PCI revision Christoph Hellwig
2016-08-04 20:14 ` [Qemu-devel] fix incorrect identify implementation in nvme Keith Busch
2016-08-05 6:48 ` Markus Armbruster
2016-08-05 8:54 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805085421.GA5503@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.