All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [bug, 4.8] /proc/meminfo: counter values are very wrong
Date: Fri, 5 Aug 2016 21:59:35 +1000	[thread overview]
Message-ID: <20160805115935.GI16044@dastard> (raw)
In-Reply-To: <20160805105417.GQ2799@techsingularity.net>

On Fri, Aug 05, 2016 at 11:54:17AM +0100, Mel Gorman wrote:
> On Fri, Aug 05, 2016 at 09:11:10AM +1000, Dave Chinner wrote:
> > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > > index fb975cec3518..baa97da3687d 100644
> > > --- a/mm/page_alloc.c
> > > +++ b/mm/page_alloc.c
> > > @@ -4064,7 +4064,7 @@ long si_mem_available(void)
> > >  	int lru;
> > >  
> > >  	for (lru = LRU_BASE; lru < NR_LRU_LISTS; lru++)
> > > -		pages[lru] = global_page_state(NR_LRU_BASE + lru);
> > > +		pages[lru] = global_node_page_state(NR_LRU_BASE + lru);
> > >  
> > >  	for_each_zone(zone)
> > >  		wmark_low += zone->watermark[WMARK_LOW];
> > 
> > OK, that makes the /proc accounting match the /sys per-node
> > accounting, but the output still looks wrong. I remove files with
> > cached pages from the filesystem (i.e. invalidate and free them),
> > yet they are apparrently still accounted as being on the
> > active/inactive LRU.
> > 
> > Reboot, then run dbench for a minute:
> > 
> > $ sudo mkfs.xfs -f /dev/pmem1
> > meta-data=/dev/pmem1             isize=512    agcount=4, agsize=524288 blks
> >          =                       sectsz=4096  attr=2, projid32bit=1
> >          =                       crc=1        finobt=1, sparse=0
> > data     =                       bsize=4096   blocks=2097152, imaxpct=25
> >          =                       sunit=0      swidth=0 blks
> > naming   =version 2              bsize=4096   ascii-ci=0 ftype=1
> > log      =internal log           bsize=4096   blocks=2560, version=2
> >          =                       sectsz=4096  sunit=1 blks, lazy-count=1
> > realtime =none                   extsz=4096   blocks=0, rtextents=0
> > $ sudo mount /dev/pmem1 /mnt/scratch
> > $ sudo dbench -t 60 -D /mnt/scratch/ 16
> > dbench version 4.00 - Copyright Andrew Tridgell 1999-2004
> > 
> 
> Is there any chance this is related to pmem1?

Nope, just reproduced it on /dev/vdc to confirm.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2016-08-05 11:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04  5:10 [bug, 4.8] /proc/meminfo: counter values are very wrong Dave Chinner
2016-08-04 12:24 ` Mel Gorman
2016-08-04 12:34   ` Mel Gorman
2016-08-04 23:11     ` Dave Chinner
2016-08-05 10:54       ` Mel Gorman
2016-08-05 11:59         ` Dave Chinner [this message]
2016-08-05 12:07           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160805115935.GI16044@dastard \
    --to=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@techsingularity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.