From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161354AbcHEMoa (ORCPT ); Fri, 5 Aug 2016 08:44:30 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37789 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935000AbcHEMo2 (ORCPT ); Fri, 5 Aug 2016 08:44:28 -0400 Date: Fri, 5 Aug 2016 13:45:17 +0100 From: Lee Jones To: Dan Gora Cc: Peter Tyser , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mfd: Use gpio-ich driver for 8-series and 9-series Intel PCH devices Message-ID: <20160805124517.GX5243@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Jul 2016, Dan Gora wrote: > > The Intel 8-series and 9-series PCH devices, described by the descriptors > LPC_LPT and LPC_9S although codenamed 'lynxpoint' do not use the same GPIO > register layout which is used by the gpio-lynxpoint driver. They use the > same ICH_V5_GPIO layout as the gpio-ich driver. > > See: > http://www.intel.com/content/www/us/en/chipsets/8-series-chipset-pch-datasheet.html > http://www.intel.com/content/www/us/en/chipsets/9-series-chipset-pch-datasheet.html > > The devices described by "Mobile 4th Generation Intel Core Processor > Family I/O" manual use the gpio-lynxpoint driver and are described by the > LPC_LPT_LP descriptor. > > See: > http://www.intel.com/content/www/us/en/processors/core/4th-gen-core-family-mobile-i-o-datasheet.html > > Signed-off-by: Dan Gora > --- > drivers/mfd/lpc_ich.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c > index bd3aa45..66f72ad 100644 > --- a/drivers/mfd/lpc_ich.c > +++ b/drivers/mfd/lpc_ich.c > @@ -493,6 +493,7 @@ static struct lpc_ich_info lpc_chipset_info[] = { > [LPC_LPT] = { > .name = "Lynx Point", > .iTCO_version = 2, > + .gpio_version = ICH_V5_GPIO, > }, > [LPC_LPT_LP] = { > .name = "Lynx Point_LP", > @@ -530,6 +531,7 @@ static struct lpc_ich_info lpc_chipset_info[] = { > [LPC_9S] = { > .name = "9 Series", > .iTCO_version = 2, > + .gpio_version = ICH_V5_GPIO, > }, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog