From: Lee Jones <lee.jones@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Florian Lobmaier <florian.lobmaier@ams.com>
Subject: Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular
Date: Fri, 5 Aug 2016 13:56:07 +0100 [thread overview]
Message-ID: <20160805125607.GZ5243@dell> (raw)
In-Reply-To: <20160706164538.GI26134@windriver.com>
On Wed, 06 Jul 2016, Paul Gortmaker wrote:
> [Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/07/2016 (Tue 11:18) Laxman Dewangan wrote:
>
> >
> > On Tuesday 05 July 2016 06:55 AM, Paul Gortmaker wrote:
> > >The Kconfig currently controlling compilation of this code is:
> > >
> > >drivers/mfd/Kconfig:config MFD_AS3722
> > >drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC"
> > >
> >
> >
> > Should we convert this to as "tristate" so that it can be built as module
> > also.
>
> Seems to compile and modpost w/o missing symbols as tristate:
>
> paul@yow-builder:~/git/linux-head$ ls -l ../arm-build/drivers/mfd/as3722*
> -rw-rw-r-- 1 paul paul 13010 Jul 6 12:30 ../arm-build/drivers/mfd/as3722.ko
> -rw-rw-r-- 1 paul paul 1937 Jul 6 12:28 ../arm-build/drivers/mfd/as3722.mod.c
> -rw-rw-r-- 1 paul paul 3820 Jul 6 12:29 ../arm-build/drivers/mfd/as3722.mod.o
> -rw-rw-r-- 1 paul paul 11292 Jul 6 12:13 ../arm-build/drivers/mfd/as3722.o
> paul@yow-builder:~/git/linux-head$
>
> ...so I'll drop this patch in favour of the one line tristate conversion in v2.
Did you ever get around to submitting a v2?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-08-05 12:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 1:25 [PATCH 0/6] mfd: trivial demodularization of non-modular drivers Paul Gortmaker
2016-07-05 1:25 ` Paul Gortmaker
2016-07-05 1:25 ` [PATCH 1/6] mfd: altera-a10sr: make it explicitly non-modular Paul Gortmaker
2016-08-05 12:57 ` Lee Jones
2016-08-23 20:56 ` Paul Gortmaker
2016-08-31 11:43 ` Lee Jones
2016-07-05 1:25 ` [PATCH 2/6] mfd: as3722: Make " Paul Gortmaker
2016-07-05 5:48 ` Laxman Dewangan
2016-07-06 16:45 ` Paul Gortmaker
2016-08-05 12:56 ` Lee Jones [this message]
2016-08-05 13:50 ` Paul Gortmaker
2016-08-08 9:14 ` Lee Jones
2016-08-08 14:01 ` Paul Gortmaker
2016-07-05 1:25 ` [PATCH 3/6] mfd: intel_msic: " Paul Gortmaker
2016-07-05 10:08 ` Mika Westerberg
2016-07-06 16:38 ` Paul Gortmaker
2016-07-07 8:11 ` Mika Westerberg
2016-07-07 10:26 ` Andy Shevchenko
2016-07-07 10:33 ` Mika Westerberg
2016-08-05 12:57 ` Lee Jones
2016-07-05 1:25 ` [PATCH 4/6] mfd: smsc-ece1099: " Paul Gortmaker
2016-08-05 12:57 ` Lee Jones
2016-07-05 1:25 ` [PATCH 5/6] mfd: sun6i-prcm: " Paul Gortmaker
2016-07-05 6:24 ` Maxime Ripard
2016-08-05 12:57 ` Lee Jones
2016-07-05 1:25 ` [PATCH 6/6] mfd: twl-core: " Paul Gortmaker
2016-07-05 1:25 ` Paul Gortmaker
2016-08-05 12:58 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805125607.GZ5243@dell \
--to=lee.jones@linaro.org \
--cc=florian.lobmaier@ams.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.