From: Theodore Ts'o <tytso@mit.edu>
To: Nikolay Borisov <kernel@kyup.com>
Cc: Jan Kara <jack@suse.cz>, Jan Kara <jack@suse.com>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: Sleeping function called in invalid context
Date: Fri, 5 Aug 2016 10:56:04 -0400 [thread overview]
Message-ID: <20160805145604.GA9105@thunk.org> (raw)
In-Reply-To: <57A43267.7030608@kyup.com>
On Fri, Aug 05, 2016 at 09:29:59AM +0300, Nikolay Borisov wrote:
> > The easist way to fix this is defer the ext4_commit_super() to a
> > workqueue. We only need this in the errors=continue case, and in that
> > scenario we're not in a hurry when the superblock gets written out.
>
> Is errors=continue the default option if nothing specifically is
> specified at mount time, since I don't have this set explicitly:
>
> /dev/vda / ext4 rw,relatime,data=ordered 0 0
Yes, it's the default. I keep wondering whether we should change the
default to remount-ro or even panic, since people sometimes don't
notice that the "file system has been corrupted" messages, and then
they can end up losing a lot more detail if we forced them to address
the issue right away.
- Ted
next prev parent reply other threads:[~2016-08-05 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 7:22 Sleeping function called in invalid context Nikolay Borisov
2016-08-04 16:05 ` Jan Kara
2016-08-04 20:58 ` Theodore Ts'o
2016-08-05 6:29 ` Nikolay Borisov
2016-08-05 14:56 ` Theodore Ts'o [this message]
2016-08-05 17:06 ` Darrick J. Wong
2016-08-11 19:52 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805145604.GA9105@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=kernel@kyup.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.