From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [CI 13/19] drm/i915: Remove (struct_mutex) locking for busy-ioctl Date: Fri, 5 Aug 2016 21:08:34 +0200 Message-ID: <20160805190834.GI6232@phenom.ffwll.local> References: <1470388464-28458-1-git-send-email-chris@chris-wilson.co.uk> <1470388464-28458-13-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BC1E6EC2B for ; Fri, 5 Aug 2016 19:08:38 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id q128so4986718wma.1 for ; Fri, 05 Aug 2016 12:08:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1470388464-28458-13-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMDUsIDIwMTYgYXQgMTA6MTQ6MThBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEJ5IGFwcGx5aW5nIHRoZSBzYW1lIGxvZ2ljIGFzIGZvciB3YWl0LWlvY3RsLCB3ZSBj YW4gcXVlcnkgd2hldGhlciBhCj4gcmVxdWVzdCBoYXMgY29tcGxldGVkIHdpdGhvdXQgaG9sZGlu ZyBzdHJ1Y3RfbXV0ZXguIFRoZSBiaWdnZXN0IGltcGFjdAo+IHN5c3RlbS13aWRlIGlzIHJlbW92 aW5nIHRoZSBmbHVzaF9hY3RpdmUgYW5kIHRoZSBjb250ZW50aW9uIHRoYXQgY2F1c2VzLgo+IAo+ IFRlc3RjYXNlOiBpZ3QvZ2VtX2J1c3kKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogQWthc2ggR29lbCA8YWthc2guZ29lbEBpbnRl bC5jb20+Cj4gUmV2aWV3ZWQtYnk6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxp bnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8 IDEzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCAxMDEgaW5zZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jCj4gaW5kZXggY2ViMDA5NzBiMmRhLi5iOTlkNjRiZmI3ZWIgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAtMzczNiw0OSArMzczNiwxMjAgQEAgaTkxNV9nZW1f b2JqZWN0X2dndHRfdW5waW5fdmlldyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ ICAJaTkxNV92bWFfdW5waW4oaTkxNV9nZW1fb2JqX3RvX2dndHRfdmlldyhvYmosIHZpZXcpKTsK PiAgfQo+ICAKPiArc3RhdGljIF9fYWx3YXlzX2lubGluZSB1bnNpZ25lZCBfX2J1c3lfcmVhZF9m bGFnKHVuc2lnbmVkIGludCBpZCkKPiArewo+ICsJLyogTm90ZSB0aGF0IHdlIGNvdWxkIGFsaWFz IGVuZ2luZXMgaW4gdGhlIGV4ZWNidWYgQVBJLCBidXQKPiArCSAqIHRoYXQgd291bGQgYmUgdmVy eSB1bndpc2UgYXMgaXQgcHJldmVudHMgdXNlcnNwYWNlIGZyb20KPiArCSAqIGZpbmUgY29udHJv bCBvdmVyIGVuZ2luZSBzZWxlY3Rpb24uIEFoZW0uCj4gKwkgKgo+ICsJICogVGhpcyBzaG91bGQg YmUgc29tZXRoaW5nIGxpa2UgRVhFQ19NQVhfRU5HSU5FIGluc3RlYWQgb2YKPiArCSAqIEk5MTVf TlVNX0VOR0lORVMuCj4gKwkgKi8KPiArCUJVSUxEX0JVR19PTihJOTE1X05VTV9FTkdJTkVTID4g MTYpOwo+ICsJcmV0dXJuIDB4MTAwMDAgPDwgaWQ7Cj4gK30KPiArCj4gK3N0YXRpYyBfX2Fsd2F5 c19pbmxpbmUgdW5zaWduZWQgaW50IF9fYnVzeV93cml0ZV9pZCh1bnNpZ25lZCBpbnQgaWQpCj4g K3sKPiArCXJldHVybiBpZDsKPiArfQo+ICsKPiArc3RhdGljIF9fYWx3YXlzX2lubGluZSB1bnNp Z25lZAo+ICtfX2J1c3lfc2V0X2lmX2FjdGl2ZShjb25zdCBzdHJ1Y3QgaTkxNV9nZW1fYWN0aXZl ICphY3RpdmUsCj4gKwkJICAgICB1bnNpZ25lZCBpbnQgKCpmbGFnKSh1bnNpZ25lZCBpbnQgaWQp KQo+ICt7Cj4gKwkvKiBGb3IgbW9yZSBkaXNjdXNzaW9uIGFib3V0IHRoZSBiYXJyaWVycyBhbmQg bG9ja2luZyBjb25jZXJucywKPiArCSAqIHNlZSBfX2k5MTVfZ2VtX2FjdGl2ZV9nZXRfcmN1KCku Cj4gKwkgKi8KPiArCWRvIHsKPiArCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVl c3Q7Cj4gKwkJdW5zaWduZWQgaW50IGlkOwo+ICsKPiArCQlyZXF1ZXN0ID0gcmN1X2RlcmVmZXJl bmNlKGFjdGl2ZS0+cmVxdWVzdCk7Cj4gKwkJaWYgKCFyZXF1ZXN0IHx8IGk5MTVfZ2VtX3JlcXVl c3RfY29tcGxldGVkKHJlcXVlc3QpKQo+ICsJCQlyZXR1cm4gMDsKPiArCj4gKwkJaWQgPSByZXF1 ZXN0LT5lbmdpbmUtPmV4ZWNfaWQ7Cj4gKwo+ICsJCS8qIENoZWNrIHRoYXQgdGhlIHBvaW50ZXIg d2Fzbid0IHJlYXNzaWduZWQgYW5kIG92ZXJ3cml0dGVuLiAqLwoKY2YuIG91ciBkaXNjdXNzaW9u IGluIGFjdGl2ZV9nZXRfcmN1IC0gdGhlcmUncyBubyBmZW5jZV9nZXRfcmN1IGluIHNpZ2h0CmFu eXdoZXJlIGhlcmUsIGhlbmNlIHRoaXMgbmVlZHMgYW4gc21wX3JtYigpLiBBbHNvIG5pdHBpY2s6 IFRoZSB0d28KcmN1X2RlcmVmZXJlbmNlKGFjdG92ZS0+cmVxdWVzdCkgZmVlbCBhIGJpdCBzaWxs eS4gSWYgd2UgbW92ZSB0aGUgZmlyc3QgaW4KZnJvbnQgb2YgdGhlIGxvb3AsIGFuZCB1cGRhdGUg dGhlIGxvY2FsIHJlcXVlc3QgcG9pbnRlciAodXNpbmcgYSB0bXApIGl0CndvdWxkIGxvb2sgdGlk aWVyLCBhbmQgd2UgY291bGQgZXZlbiBtb3ZlIHRoZSBsb29wIHRlcm1pbmF0aW9uIGNvbmRpdGlv bgppbnRvIHRoZSB3aGlsZSAoKSBjaGVjayAoYW5kIG1vdmUgdGhlIHJldHVybiBmbGFnKGlkKSBh dCB0aGUgZW5kIG9mIHRoZQpmdW5jdGlvbikuCi1EYW5pZWwKCj4gKwkJaWYgKHJlcXVlc3QgPT0g cmN1X2FjY2Vzc19wb2ludGVyKGFjdGl2ZS0+cmVxdWVzdCkpCj4gKwkJCXJldHVybiBmbGFnKGlk KTsKPiArCX0gd2hpbGUgKDEpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW5saW5lIHVuc2lnbmVkCj4g K2J1c3lfY2hlY2tfcmVhZGVyKGNvbnN0IHN0cnVjdCBpOTE1X2dlbV9hY3RpdmUgKmFjdGl2ZSkK PiArewo+ICsJcmV0dXJuIF9fYnVzeV9zZXRfaWZfYWN0aXZlKGFjdGl2ZSwgX19idXN5X3JlYWRf ZmxhZyk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbmxpbmUgdW5zaWduZWQKPiArYnVzeV9jaGVja193 cml0ZXIoY29uc3Qgc3RydWN0IGk5MTVfZ2VtX2FjdGl2ZSAqYWN0aXZlKQo+ICt7Cj4gKwlyZXR1 cm4gX19idXN5X3NldF9pZl9hY3RpdmUoYWN0aXZlLCBfX2J1c3lfd3JpdGVfaWQpOwo+ICt9Cj4g Kwo+ICBpbnQKPiAgaTkxNV9nZW1fYnVzeV9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2 b2lkICpkYXRhLAo+ICAJCSAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gIHsKPiAgCXN0cnVj dCBkcm1faTkxNV9nZW1fYnVzeSAqYXJncyA9IGRhdGE7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X29iamVjdCAqb2JqOwo+IC0JaW50IHJldDsKPiAtCj4gLQlyZXQgPSBpOTE1X211dGV4X2xvY2tf aW50ZXJydXB0aWJsZShkZXYpOwo+IC0JaWYgKHJldCkKPiAtCQlyZXR1cm4gcmV0Owo+ICsJdW5z aWduZWQgbG9uZyBhY3RpdmU7Cj4gIAo+ICAJb2JqID0gaTkxNV9nZW1fb2JqZWN0X2xvb2t1cChm aWxlLCBhcmdzLT5oYW5kbGUpOwo+IC0JaWYgKCFvYmopIHsKPiAtCQlyZXQgPSAtRU5PRU5UOwo+ IC0JCWdvdG8gdW5sb2NrOwo+IC0JfQo+ICsJaWYgKCFvYmopCj4gKwkJcmV0dXJuIC1FTk9FTlQ7 Cj4gIAo+IC0JLyogQ291bnQgYWxsIGFjdGl2ZSBvYmplY3RzIGFzIGJ1c3ksIGV2ZW4gaWYgdGhl eSBhcmUgY3VycmVudGx5IG5vdCB1c2VkCj4gLQkgKiBieSB0aGUgZ3B1LiBVc2VycyBvZiB0aGlz IGludGVyZmFjZSBleHBlY3Qgb2JqZWN0cyB0byBldmVudHVhbGx5Cj4gLQkgKiBiZWNvbWUgbm9u LWJ1c3kgd2l0aG91dCBhbnkgZnVydGhlciBhY3Rpb25zLgo+IC0JICovCj4gIAlhcmdzLT5idXN5 ID0gMDsKPiAtCWlmIChpOTE1X2dlbV9vYmplY3RfaXNfYWN0aXZlKG9iaikpIHsKPiAtCQlzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcTsKPiAtCQlpbnQgaTsKPiArCWFjdGl2ZSA9IF9f STkxNV9CT19BQ1RJVkUob2JqKTsKPiArCWlmIChhY3RpdmUpIHsKPiArCQlpbnQgaWR4Owo+ICAK PiAtCQlmb3IgKGkgPSAwOyBpIDwgSTkxNV9OVU1fRU5HSU5FUzsgaSsrKSB7Cj4gLQkJCXJlcSA9 IGk5MTVfZ2VtX2FjdGl2ZV9wZWVrKCZvYmotPmxhc3RfcmVhZFtpXSwKPiAtCQkJCQkJICAgJm9i ai0+YmFzZS5kZXYtPnN0cnVjdF9tdXRleCk7Cj4gLQkJCWlmIChyZXEpCj4gLQkJCQlhcmdzLT5i dXN5IHw9IDEgPDwgKDE2ICsgcmVxLT5lbmdpbmUtPmV4ZWNfaWQpOwo+IC0JCX0KPiAtCQlyZXEg PSBpOTE1X2dlbV9hY3RpdmVfcGVlaygmb2JqLT5sYXN0X3dyaXRlLAo+IC0JCQkJCSAgICZvYmot PmJhc2UuZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC0JCWlmIChyZXEpCj4gLQkJCWFyZ3MtPmJ1c3kg fD0gcmVxLT5lbmdpbmUtPmV4ZWNfaWQ7Cj4gKwkJLyogWWVzLCB0aGUgbG9va3VwcyBhcmUgaW50 ZW50aW9uYWxseSByYWN5Lgo+ICsJCSAqCj4gKwkJICogRmlyc3QsIHdlIGNhbm5vdCBzaW1wbHkg cmVseSBvbiBfX0k5MTVfQk9fQUNUSVZFLiBXZSBoYXZlCj4gKwkJICogdG8gcmVnYXJkIHRoZSB2 YWx1ZSBhcyBzdGFsZSBhbmQgYXMgb3VyIEFCSSBndWFyYW50ZWVzCj4gKwkJICogZm9yd2FyZCBw cm9ncmVzcywgd2UgY29uZmlybSB0aGUgc3RhdHVzIG9mIGVhY2ggYWN0aXZlCj4gKwkJICogcmVx dWVzdCB3aXRoIHRoZSBoYXJkd2FyZS4KPiArCQkgKgo+ICsJCSAqIEV2ZW4gdGhvdWdoIHdlIGd1 YXJkIHRoZSBwb2ludGVyIGxvb2t1cCBieSBSQ1UsIHRoYXQgb25seQo+ICsJCSAqIGd1YXJhbnRl ZXMgdGhhdCB0aGUgcG9pbnRlciBhbmQgaXRzIGNvbnRlbnRzIHJlbWFpbgo+ICsJCSAqIGRlcmVm ZXJlbmNhYmxlIGFuZCBkb2VzICpub3QqIG1lYW4gdGhhdCB0aGUgcmVxdWVzdCB3ZQo+ICsJCSAq IGhhdmUgaXMgdGhlIHNhbWUgYXMgdGhlIG9uZSBiZWluZyB0cmFja2VkIGJ5IHRoZSBvYmplY3Qu Cj4gKwkJICoKPiArCQkgKiBDb25zaWRlciB0aGF0IHdlIGxvb2t1cCB0aGUgcmVxdWVzdCBqdXN0 IGFzIGl0IGlzIGJlaW5nCj4gKwkJICogcmV0aXJlZCBhbmQgZnJlZWQuIFdlIHRha2UgYSBsb2Nh bCBjb3B5IG9mIHRoZSBwb2ludGVyLAo+ICsJCSAqIGJ1dCBiZWZvcmUgd2UgYWRkIGl0cyBlbmdp bmUgaW50byB0aGUgYnVzeSBzZXQsIHRoZSBvdGhlcgo+ICsJCSAqIHRocmVhZCByZWFsbG9jYXRl cyBpdCBhbmQgYXNzaWducyBpdCB0byBhIHRhc2sgb24gYW5vdGhlcgo+ICsJCSAqIGVuZ2luZSB3 aXRoIGEgZnJlc2ggYW5kIGluY29tcGxldGUgc2Vxbm8uCj4gKwkJICoKPiArCQkgKiBTbyBhZnRl ciB3ZSBsb29rdXAgdGhlIGVuZ2luZSdzIGlkLCB3ZSBkb3VibGUgY2hlY2sgdGhhdAo+ICsJCSAq IHRoZSBhY3RpdmUgcmVxdWVzdCBpcyB0aGUgc2FtZSBhbmQgb25seSB0aGVuIGRvIHdlIGFkZCBp dAo+ICsJCSAqIGludG8gdGhlIGJ1c3kgc2V0Lgo+ICsJCSAqLwo+ICsJCXJjdV9yZWFkX2xvY2so KTsKPiArCj4gKwkJZm9yX2VhY2hfYWN0aXZlKGFjdGl2ZSwgaWR4KQo+ICsJCQlhcmdzLT5idXN5 IHw9IGJ1c3lfY2hlY2tfcmVhZGVyKCZvYmotPmxhc3RfcmVhZFtpZHhdKTsKPiArCj4gKwkJLyog Rm9yIEFCSSBzYW5pdHksIHdlIG9ubHkgY2FyZSB0aGF0IHRoZSB3cml0ZSBlbmdpbmUgaXMgaW4K PiArCQkgKiB0aGUgc2V0IG9mIHJlYWQgZW5naW5lcy4gVGhpcyBpcyBlbnN1cmVkIGJ5IHRoZSBv cmRlcmluZwo+ICsJCSAqIG9mIHNldHRpbmcgbGFzdF9yZWFkL2xhc3Rfd3JpdGUgaW4gaTkxNV92 bWFfbW92ZV90b19hY3RpdmUsCj4gKwkJICogYW5kIHRoZW4gaW4gcmV2ZXJzZSBpbiByZXRpcmUu Cj4gKwkJICoKPiArCQkgKiBXZSBkb24ndCBjYXJlIHRoYXQgdGhlIHNldCBvZiBhY3RpdmUgcmVh ZC93cml0ZSBlbmdpbmVzCj4gKwkJICogbWF5IGNoYW5nZSBkdXJpbmcgY29uc3RydWN0aW9uIG9m IHRoZSByZXN1bHQsIGFzIGl0IGlzCj4gKwkJICogZXF1YWxseSBsaWFibGUgdG8gY2hhbmdlIGJl Zm9yZSB1c2Vyc3BhY2UgY2FuIGluc3BlY3QKPiArCQkgKiB0aGUgcmVzdWx0Lgo+ICsJCSAqLwo+ ICsJCWFyZ3MtPmJ1c3kgfD0gYnVzeV9jaGVja193cml0ZXIoJm9iai0+bGFzdF93cml0ZSk7Cj4g Kwo+ICsJCXJjdV9yZWFkX3VubG9jaygpOwo+ICAJfQo+ICAKPiAtCWk5MTVfZ2VtX29iamVjdF9w dXQob2JqKTsKPiAtdW5sb2NrOgo+IC0JbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7 Cj4gLQlyZXR1cm4gcmV0Owo+ICsJaTkxNV9nZW1fb2JqZWN0X3B1dF91bmxvY2tlZChvYmopOwo+ ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIGludAo+IC0tIAo+IDIuOC4xCj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==