From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [CI 13/19] drm/i915: Remove (struct_mutex) locking for busy-ioctl Date: Fri, 5 Aug 2016 22:12:44 +0200 Message-ID: <20160805201244.GN6232@phenom.ffwll.local> References: <1470388464-28458-1-git-send-email-chris@chris-wilson.co.uk> <1470388464-28458-13-git-send-email-chris@chris-wilson.co.uk> <20160805190834.GI6232@phenom.ffwll.local> <20160805193042.GN24508@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id C6F426EC42 for ; Fri, 5 Aug 2016 20:12:48 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id x83so5164546wma.3 for ; Fri, 05 Aug 2016 13:12:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160805193042.GN24508@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMDUsIDIwMTYgYXQgMDg6MzA6NDJQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIEZyaSwgQXVnIDA1LCAyMDE2IGF0IDA5OjA4OjM0UE0gKzAyMDAsIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPiBPbiBGcmksIEF1ZyAwNSwgMjAxNiBhdCAxMDoxNDoxOEFNICswMTAw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiA+IEJ5IGFwcGx5aW5nIHRoZSBzYW1lIGxvZ2ljIGFz IGZvciB3YWl0LWlvY3RsLCB3ZSBjYW4gcXVlcnkgd2hldGhlciBhCj4gPiA+IHJlcXVlc3QgaGFz IGNvbXBsZXRlZCB3aXRob3V0IGhvbGRpbmcgc3RydWN0X211dGV4LiBUaGUgYmlnZ2VzdCBpbXBh Y3QKPiA+ID4gc3lzdGVtLXdpZGUgaXMgcmVtb3ZpbmcgdGhlIGZsdXNoX2FjdGl2ZSBhbmQgdGhl IGNvbnRlbnRpb24gdGhhdCBjYXVzZXMuCj4gPiA+IAo+ID4gPiBUZXN0Y2FzZTogaWd0L2dlbV9i dXN5Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u LmNvLnVrPgo+ID4gPiBDYzogQWthc2ggR29lbCA8YWthc2guZ29lbEBpbnRlbC5jb20+Cj4gPiA+ IFJldmlld2VkLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRl bC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8 IDEzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCj4gPiA+ICAxIGZp bGUgY2hhbmdlZCwgMTAxIGluc2VydGlvbnMoKyksIDMwIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiA+IGluZGV4IGNlYjAwOTcwYjJkYS4uYjk5ZDY0 YmZiN2ViIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j Cj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+ID4gQEAgLTM3 MzYsNDkgKzM3MzYsMTIwIEBAIGk5MTVfZ2VtX29iamVjdF9nZ3R0X3VucGluX3ZpZXcoc3RydWN0 IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiA+ID4gIAlpOTE1X3ZtYV91bnBpbihpOTE1X2dl bV9vYmpfdG9fZ2d0dF92aWV3KG9iaiwgdmlldykpOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICtz dGF0aWMgX19hbHdheXNfaW5saW5lIHVuc2lnbmVkIF9fYnVzeV9yZWFkX2ZsYWcodW5zaWduZWQg aW50IGlkKQo+ID4gPiArewo+ID4gPiArCS8qIE5vdGUgdGhhdCB3ZSBjb3VsZCBhbGlhcyBlbmdp bmVzIGluIHRoZSBleGVjYnVmIEFQSSwgYnV0Cj4gPiA+ICsJICogdGhhdCB3b3VsZCBiZSB2ZXJ5 IHVud2lzZSBhcyBpdCBwcmV2ZW50cyB1c2Vyc3BhY2UgZnJvbQo+ID4gPiArCSAqIGZpbmUgY29u dHJvbCBvdmVyIGVuZ2luZSBzZWxlY3Rpb24uIEFoZW0uCj4gPiA+ICsJICoKPiA+ID4gKwkgKiBU aGlzIHNob3VsZCBiZSBzb21ldGhpbmcgbGlrZSBFWEVDX01BWF9FTkdJTkUgaW5zdGVhZCBvZgo+ ID4gPiArCSAqIEk5MTVfTlVNX0VOR0lORVMuCj4gPiA+ICsJICovCj4gPiA+ICsJQlVJTERfQlVH X09OKEk5MTVfTlVNX0VOR0lORVMgPiAxNik7Cj4gPiA+ICsJcmV0dXJuIDB4MTAwMDAgPDwgaWQ7 Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBfX2Fsd2F5c19pbmxpbmUgdW5zaWduZWQg aW50IF9fYnVzeV93cml0ZV9pZCh1bnNpZ25lZCBpbnQgaWQpCj4gPiA+ICt7Cj4gPiA+ICsJcmV0 dXJuIGlkOwo+ID4gPiArfQo+ID4gPiArCj4gPiA+ICtzdGF0aWMgX19hbHdheXNfaW5saW5lIHVu c2lnbmVkCj4gPiA+ICtfX2J1c3lfc2V0X2lmX2FjdGl2ZShjb25zdCBzdHJ1Y3QgaTkxNV9nZW1f YWN0aXZlICphY3RpdmUsCj4gPiA+ICsJCSAgICAgdW5zaWduZWQgaW50ICgqZmxhZykodW5zaWdu ZWQgaW50IGlkKSkKPiA+ID4gK3sKPiA+ID4gKwkvKiBGb3IgbW9yZSBkaXNjdXNzaW9uIGFib3V0 IHRoZSBiYXJyaWVycyBhbmQgbG9ja2luZyBjb25jZXJucywKPiA+ID4gKwkgKiBzZWUgX19pOTE1 X2dlbV9hY3RpdmVfZ2V0X3JjdSgpLgo+ID4gPiArCSAqLwo+ID4gPiArCWRvIHsKPiA+ID4gKwkJ c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0Owo+ID4gPiArCQl1bnNpZ25lZCBp bnQgaWQ7Cj4gPiA+ICsKPiA+ID4gKwkJcmVxdWVzdCA9IHJjdV9kZXJlZmVyZW5jZShhY3RpdmUt PnJlcXVlc3QpOwo+ID4gPiArCQlpZiAoIXJlcXVlc3QgfHwgaTkxNV9nZW1fcmVxdWVzdF9jb21w bGV0ZWQocmVxdWVzdCkpCj4gPiA+ICsJCQlyZXR1cm4gMDsKPiA+ID4gKwo+ID4gPiArCQlpZCA9 IHJlcXVlc3QtPmVuZ2luZS0+ZXhlY19pZDsKPiA+ID4gKwo+ID4gPiArCQkvKiBDaGVjayB0aGF0 IHRoZSBwb2ludGVyIHdhc24ndCByZWFzc2lnbmVkIGFuZCBvdmVyd3JpdHRlbi4gKi8KPiA+IAo+ ID4gY2YuIG91ciBkaXNjdXNzaW9uIGluIGFjdGl2ZV9nZXRfcmN1IC0gdGhlcmUncyBubyBmZW5j ZV9nZXRfcmN1IGluIHNpZ2h0Cj4gPiBhbnl3aGVyZSBoZXJlLCBoZW5jZSB0aGlzIG5lZWRzIGFu IHNtcF9ybWIoKS4KPiAKPiBJIHRveWVkIHdpdGggc21wX3JtYigpLiAKPiAKPiBUaGUgcmN1X2Rl ZmVyZW5jZSgpIGZvbGxvd2VkIGJ5IHJjdV9hY2Nlc3NfcG9pbnRlcigpIGlzIG9yZGVyZWQuCj4g Cj4gU28gSSB3YXMgYmFjayB3aXRoIGRhbmNpbmcgYXJvdW5kICJ3aGVyZSB0aGUgZGVwZW5kZW50 LXJlYWRzIG9yZGVyZWQgYnkgCj4gdGhlIGZpcnN0IHJjdV9kZWZlcmVuY2Ugb3JkZXJlZCBpbiBm cm9udCBvZiB0aGUgc2Vjb25kIGFjY2VzcyB3aGljaCB3YXMKPiBpdHNlbGYgb3JkZXJlZCBhZnRl ciB0aGUgZmlyc3Q/IiBJIHByb2JhYmx5IHNob3VsZAo+IGhhdmUgc3R1Y2sgaW4gdGhlIHNtcF9y bWIoKSBhbmQgc3RvcHBlZCB3b3JyeWluZyAtIGl0IGlzIHN0aWxsIGdvaW5nIHRvCj4gYmUgY2hl YXBlciB0aGFuIHRoZSByZWZjb3VudCB0cmFmZmljLgoKSXQncyB0aGUgcmVhZCBvZiBleGVjX2lk IHZzLiB0aGUgMm5kIHJlYWQgb2YgcmVxdWVzdCB3aGljaCBpc24ndCBvcmRlcmVkLAphbmQgd2hp Y2ggd2Ugd2FudCB0byBiZSBvcmRlcmVkIHRvIGVuc3VyZSB3ZSByZWFkIHRoZSByaWdodCBlbmdp bmUgaWQgKGFuZApub3Qgc29tZSBib2d1cyB0aGluZyBzaW5jZSB0aGUgcmVxdWVzdCB3YXMgcmVj eWNsZWQgbWVhbndoaWxlKS4gQW5kIEkKdGhpbmsgdGhlIHNtcF9ybWIoKSBpcyBpbmRlZWQgcmVx dWlyZWQgaW4gdGhlcmU6CgoxLiBmaXJzdCBhY3RpdmUtPnJlcXVlc3QgbG9va3VwCjIuIDJuZCBh Y3RpdmUtPnJlcXVlc3QgbG9va3VwIChjb21waWxlci9jcHUgaXMgYWxsb3dlZCB0byBkbyB0aGF0 LCBJIHRoaW5rIGl0CmNvdWxkIGV2ZW4gcmVvcmRlciBhaGVhZCBvZiAxIHNpbmNlIGl0J3Mgbm90 IGEgZGVwZW5kZW50IHJlYWQpCgo8LSBncHUgY29tcGxldGVzIHJlcXVlc3QsIGV2aWwgb3RoZXIg dGhyZWFkIGRvZXMgYWxsIHRoZSBjbGVhbiZyZWN5Y2xlcwp3aXRoIG5ldyBib2d1cyBlbmdpbmUK CjMuIHNhbXBsZSB0aGUgZW5naW5lLT5leGVjX2lkCjQuIGJhaWwgb3V0IG9mIHRoZSBsb29wIHNp bmMgcmVxdWVzdHMgbG9va2VkIHVwIGluIDEmMiBtYXRjaC4KCj4gPiBBbHNvIG5pdHBpY2s6IFRo ZSB0d28KPiA+IHJjdV9kZXJlZmVyZW5jZShhY3RvdmUtPnJlcXVlc3QpIGZlZWwgYSBiaXQgc2ls bHkuIElmIHdlIG1vdmUgdGhlIGZpcnN0IGluCj4gPiBmcm9udCBvZiB0aGUgbG9vcCwgYW5kIHVw ZGF0ZSB0aGUgbG9jYWwgcmVxdWVzdCBwb2ludGVyICh1c2luZyBhIHRtcCkgaXQKPiA+IHdvdWxk IGxvb2sgdGlkaWVyLCBhbmQgd2UgY291bGQgZXZlbiBtb3ZlIHRoZSBsb29wIHRlcm1pbmF0aW9u IGNvbmRpdGlvbgo+ID4gaW50byB0aGUgd2hpbGUgKCkgY2hlY2sgKGFuZCBtb3ZlIHRoZSByZXR1 cm4gZmxhZyhpZCkgYXQgdGhlIGVuZCBvZiB0aGUKPiA+IGZ1bmN0aW9uKS4KPiAKPiBJIHdhcyBx dWl0ZSBjb250ZW50IHdpdGggb25seSBoYXZpbmcgdG8gdGhpbmsgb2Ygb25lIHBoYXNlIHRocm91 Z2ggdGhlCj4gbG9vcCBhbmQgbm90IHdvcnJ5IGFib3V0IHN0YXRlIGJlaW5nIGNhcnJpZWQgZm9y d2FyZC4KPiAKPiAgX19idXN5X3NldF9pZl9hY3RpdmUoY29uc3Qgc3RydWN0IGk5MTVfZ2VtX2Fj dGl2ZSAqYWN0aXZlLAo+ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCAoKmZsYWcp KHVuc2lnbmVkIGludCBpZCkpCj4gIHsKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVx dWVzdCAqcmVxdWVzdDsKPiArICAgICAgIHVuc2lnbmVkIGludCBpZDsKPiArCj4gICAgICAgICAv KiBGb3IgbW9yZSBkaXNjdXNzaW9uIGFib3V0IHRoZSBiYXJyaWVycyBhbmQgbG9ja2luZyBjb25j ZXJucywKPiAgICAgICAgICAqIHNlZSBfX2k5MTVfZ2VtX2FjdGl2ZV9nZXRfcmN1KCkuCj4gICAg ICAgICAgKi8KPiArICAgICAgIHJlcXVlc3QgPSByY3VfZGVyZWZlcmVuY2UoYWN0aXZlLT5yZXF1 ZXN0KTsKPiAgICAgICAgIGRvIHsKPiAtICAgICAgICAgICAgICAgc3RydWN0IGRybV9pOTE1X2dl bV9yZXF1ZXN0ICpyZXF1ZXN0Owo+IC0gICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgaWQ7Cj4g KyAgICAgICAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqdG1wOwo+ICAKPiAt ICAgICAgICAgICAgICAgcmVxdWVzdCA9IHJjdV9kZXJlZmVyZW5jZShhY3RpdmUtPnJlcXVlc3Qp Owo+ICAgICAgICAgICAgICAgICBpZiAoIXJlcXVlc3QgfHwgaTkxNV9nZW1fcmVxdWVzdF9jb21w bGV0ZWQocmVxdWVzdCkpCj4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gIAo+ ICAgICAgICAgICAgICAgICBpZCA9IHJlcXVlc3QtPmVuZ2luZS0+ZXhlY19pZDsKPiAgCj4gICAg ICAgICAgICAgICAgIC8qIENoZWNrIHRoYXQgdGhlIHBvaW50ZXIgd2Fzbid0IHJlYXNzaWduZWQg YW5kIG92ZXJ3cml0dGVuLiAqLwo+IC0gICAgICAgICAgICAgICBpZiAocmVxdWVzdCA9PSByY3Vf YWNjZXNzX3BvaW50ZXIoYWN0aXZlLT5yZXF1ZXN0KSkKPiAtICAgICAgICAgICAgICAgICAgICAg ICByZXR1cm4gZmxhZyhpZCk7Cj4gKyAgICAgICAgICAgICAgIHRtcCA9IHJjdV9kZXJlZmVyZW5j ZShhY3RpdmUtPnJlcXVlc3QpOwo+ICsgICAgICAgICAgICAgICBpZiAodG1wID09IHJlcXVlc3Qp Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gKwo+ICsgICAgICAgICAgICAgICBy ZXF1ZXN0ID0gdG1wOwo+ICAgICAgICAgfSB3aGlsZSAoMSk7Cj4gKwo+ICsgICAgICAgcmV0dXJu IGZsYWcoaWQpOwo+ICB9Cj4gCj4gaXMgYWxzbyBub3QgYXMgd2VsbCBvcHRpbWlzZWQgYnkgZ2Nj LCBhcHBhcmVudGx5LgoKSG0geWVhaCwgdW5kZXJ3aGVsbWluZy4gSSdtIG9rIHdpdGggZWl0aGVy IEkgZ3Vlc3MuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=