From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Simple (re)broadcast avoidance
Date: Sat, 6 Aug 2016 03:11:12 +0200 [thread overview]
Message-ID: <20160806011112.GC4299@otheros> (raw)
In-Reply-To: <1877539.fInDOEgoYM@bentobox>
On Thu, Aug 04, 2016 at 07:56:44AM +0200, Sven Eckelmann wrote:
> Ok, looks like the neigh_list edge in my graph is incorrectly there. But what
> about last_bonding_candidate? This definitely has a reference counter (and
> needs it) and thus your code would cause problems when bonding is enabled.
One more tiny thing, that I noticed during rereading & playing
with that part of the code:
The usage of orig_node->last_bonding_candidate looks a lot like
rcu-pointer style. However it is read & set without any
rcu_dereference() / rcu_assign() wrappers.
Is something else protecting a simultaneous read (for instance from
the neighbor table output) of last_bonding_candidate while being
changed via batadv_last_bonding_replace()?
next prev parent reply other threads:[~2016-08-06 1:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 20:38 [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove unused skb_reset_mac_header() Linus Lüssing
2016-08-01 20:38 ` [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Simple (re)broadcast avoidance Linus Lüssing
2016-08-03 19:59 ` Sven Eckelmann
2016-08-03 21:25 ` Linus Lüssing
2016-08-03 23:43 ` Linus Lüssing
2016-08-04 5:56 ` Sven Eckelmann
2016-08-04 6:09 ` Sven Eckelmann
2016-08-06 1:11 ` Linus Lüssing [this message]
2016-08-06 8:13 ` Sven Eckelmann
2016-08-06 19:58 ` Linus Lüssing
2016-08-04 7:29 ` Sven Eckelmann
2016-08-06 1:04 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160806011112.GC4299@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.