From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libcofi: disable for static-only builds
Date: Sun, 7 Aug 2016 22:08:48 +0200 [thread overview]
Message-ID: <20160807200848.GE5855@free.fr> (raw)
In-Reply-To: <1470558003-19548-1-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2016-08-07 10:20 +0200, Thomas Petazzoni spake thusly:
> The libcofi package unconditionally builds a shared library, so we need
> to make it unavailable on BR2_STATIC_LIBS=y configurations.
Given that the expected use of libcofi is via LD_PRELOAD, this makes
sense.
(Technically, nothing would prevent linking with it at build time,
though.)
> Fixes:
>
> http://autobuild.buildroot.net/results/329c09bf123cd5b6dbcfff6251ba7a2c7cce50b8/
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/libcofi/Config.in | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/libcofi/Config.in b/package/libcofi/Config.in
> index e9914d6..df9ab71 100644
> --- a/package/libcofi/Config.in
> +++ b/package/libcofi/Config.in
> @@ -1,8 +1,14 @@
> config BR2_PACKAGE_LIBCOFI
> bool "libcofi"
> depends on BR2_arm
> + # builds a shared library
> + depends on !BR2_STATIC_LIBS
> help
> A replacement for memcpy and memset functionality for the
> Raspberry Pi with the intention of gaining greater performance.
>
> https://github.com/simonjhall/copies-and-fills
> +
> +comment "libcofi needs a toolchain w/ dynamic library"
> + depends on BR2_arm
> + depends on BR2_STATIC_LIBS
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-08-07 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 8:20 [Buildroot] [PATCH] libcofi: disable for static-only builds Thomas Petazzoni
2016-08-07 20:08 ` Yann E. MORIN [this message]
2016-08-07 21:00 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160807200848.GE5855@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.