All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] iproute2: fix no-thread build
Date: Sun, 7 Aug 2016 23:05:36 +0200	[thread overview]
Message-ID: <20160807230536.444ce384@free-electrons.com> (raw)
In-Reply-To: <1470416880-16148-1-git-send-email-thomas.petazzoni@free-electrons.com>

Hello,

On Fri,  5 Aug 2016 19:07:59 +0200, Thomas Petazzoni wrote:
> iproute2 believes that it needs to link with libpthread for its arpd
> binary, because "some db implementations require thread". Therefore, our
> iproute2.mk explicitly disables the build of arpd when thread support is
> not available.
> 
> However, the sed expression it uses no longer works. The Makefile used
> to look like:
> 
> TARGETS = foo baz baz arpd foobar
> 
> so replacing " arpd " with a space was working fine. However, the
> Makefile got changed in iproute2 to:
> 
> ifeq (... berkeleydb available ...)
>      TARGETS += arpd
> endif
> 
> i.e, with no space at the end of the line. This made our sed expression
> ineffective, causing build issues with no-thread configurations since
> arpd was no longer disabled.
> 
> To address this, instead of sed-ing the Makefile, we overwrite the
> berkeleydb detection of iproute2, by writing to the "Config" file, like
> we're doing for other aspects of the package.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/03a37a2372a4c2e438a073e015c49d9e554b86b7/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/iproute2/iproute2.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both patches applied.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-08-07 21:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05 17:07 [Buildroot] [PATCH 1/2] iproute2: fix no-thread build Thomas Petazzoni
2016-08-05 17:08 ` [Buildroot] [PATCH 2/2] iproute2: use @D instead of IPROUTE2_DIR Thomas Petazzoni
2016-08-07 20:20   ` Yann E. MORIN
2016-08-07 20:17 ` [Buildroot] [PATCH 1/2] iproute2: fix no-thread build Yann E. MORIN
2016-08-07 21:05 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160807230536.444ce384@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.