Re: [PATCH v2 6/6] xl: use xenconsole startup protocol

[Wei Liu <wei.liu2@citrix.com>]

On Mon, Aug 08, 2016 at 11:17:20AM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v2 6/6] xl: use xenconsole startup protocol"):
> > If user asks xl to automatically connect to console when creating a
> > guest, use the new startup protocol before trying to unpause domain so
> > that we don't lose any console output.
> ...
> >      if ( dom_info->console_autoconnect ) {
> > +        if (libxl_pipe(ctx, notify_pipe)) {
> > +            fprintf(stderr,
> > +                    "Failed to create console notification pipe, errno %d\n",
> > +                    errno);
> 
> Is it really necessary to print to stderr, when libxl_pipe has already
> logged a message ?  That seems the compelling advantage of
> libxl_pipe...
> 

OK. I can delete this fprintf.

> > +        else if (r == 1 && buf[0] != 0x00)
> > +            fprintf(stderr, "Got unexpected response from xenconsole: %x\n",
> > +                    buf[0]);
> 
> I would generally prefer %#x, but up to you.
> 

Done.

> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 

Thanks.

> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel