From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbcHHNib (ORCPT ); Mon, 8 Aug 2016 09:38:31 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:36599 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbcHHNi2 (ORCPT ); Mon, 8 Aug 2016 09:38:28 -0400 Date: Mon, 8 Aug 2016 14:39:53 +0100 From: Lee Jones To: Peter Chen Cc: linux-kernel@vger.kernel.org, Bjorn Andersson Subject: Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle Message-ID: <20160808133953.GR5243@dell> References: <1468575526-25074-1-git-send-email-peter.chen@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1468575526-25074-1-git-send-email-peter.chen@nxp.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jul 2016, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Bjorn Andersson > Cc: Lee Jones > Signed-off-by: Peter Chen > --- > drivers/mfd/qcom_rpm.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c > index 2e44323..ecca115 100644 > --- a/drivers/mfd/qcom_rpm.c > +++ b/drivers/mfd/qcom_rpm.c > @@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev) > } > > rpm->ipc_regmap = syscon_node_to_regmap(syscon_np); > + of_node_put(syscon_np); > if (IS_ERR(rpm->ipc_regmap)) > return PTR_ERR(rpm->ipc_regmap); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog