From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbcHHVcj (ORCPT ); Mon, 8 Aug 2016 17:32:39 -0400 Received: from tex.lwn.net ([70.33.254.29]:44309 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbcHHVci (ORCPT ); Mon, 8 Aug 2016 17:32:38 -0400 Date: Mon, 8 Aug 2016 15:32:35 -0600 From: Jonathan Corbet To: Daniel Vetter Cc: LKML , Jani Nikula , Markus Heiser , Daniel Vetter Subject: Re: [PATCH] Revert "Revert "doc/sphinx: Enable keep_warnings"" Message-ID: <20160808153235.188f6d1d@lwn.net> In-Reply-To: <1470673391-13635-1-git-send-email-daniel.vetter@ffwll.ch> References: <1470673391-13635-1-git-send-email-daniel.vetter@ffwll.ch> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Aug 2016 18:23:11 +0200 Daniel Vetter wrote: > Even with Markus fixes to the importer I still get warnigns from > sphinx which are entirely bogus :( > > /home/daniel/linux/src/Documentation/gpu/drm-kms.rst:13: WARNING: Could not lex literal_block as "C". Highlighting skipped. > /home/daniel/linux/src/Documentation/gpu/drm-kms-helpers.rst:16: WARNING: Could not lex literal_block as "C". Highlighting skipped. > /home/daniel/linux/src/Documentation/gpu/i915.rst:57: WARNING: Could not lex literal_block as "C". Highlighting skipped. > > Well it's worse: Those are warnings which don't even show up with this > enabled. Just sending this out again in the hopes some has a clue > what's going on. So I honestly think we should just set the highlight language to "none" by default. The syntax highlighting in code samples adds some colorful sugar to the docs, but it's not really all that useful, IMO, and people who want it can override the language in the right places. Any strong opposition to this idea? jon