All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: "Johannes Stezenbach" <js@sig21.net>,
	"Török Edwin" <edwin@etorok.net>,
	linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: 4.7.0-rc7 ext4 error in dx_probe
Date: Mon, 8 Aug 2016 12:08:18 -0400	[thread overview]
Message-ID: <20160808160818.GA9515@thunk.org> (raw)
In-Reply-To: <20160808062810.GC8590@birch.djwong.org>

On Sun, Aug 07, 2016 at 11:28:10PM -0700, Darrick J. Wong wrote:
> 
> I have one lingering concern -- is it a bug that two processes could be
> computing the checksum of a buffer simultaneously?  I would have thought ext4
> would serialize that kind of buffer_head access...

Do we know how this is happening?  We've always depended on the VFS to
provide this exclusion.  The only way we should be modifying the
buffer_head at the same time if two CPU's are trying to modify the
directory at the same time, and that should _never_ be happening, even
with the new directory parallism code, unless the file system has
given permission and intends to do its own fine-grained locking.

      		     	     	       	   - Ted

  reply	other threads:[~2016-08-08 16:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 10:57 4.7.0-rc7 ext4 error in dx_probe Johannes Stezenbach
2016-07-18 13:38 ` Theodore Ts'o
2016-07-18 14:17   ` Johannes Stezenbach
2016-07-27 11:58     ` Johannes Stezenbach
2016-08-03 14:50     ` Török Edwin
2016-08-05 10:35       ` Johannes Stezenbach
2016-08-05 17:02         ` Darrick J. Wong
2016-08-05 18:11           ` Johannes Stezenbach
2016-08-05 19:15             ` Darrick J. Wong
2016-08-08  3:56               ` Theodore Ts'o
2016-08-08  6:28                 ` Darrick J. Wong
2016-08-08 16:08                   ` Theodore Ts'o [this message]
2016-08-08 16:55                     ` Darrick J. Wong
2016-08-08 21:13                       ` Török Edwin
2016-08-09  2:37                         ` Darrick J. Wong
2016-08-09  7:12                           ` Török Edwin
2016-08-17 14:27                   ` Török Edwin
2016-08-17 23:28                     ` Darrick J. Wong
2016-08-22  7:33                       ` Török Edwin
2016-09-01 16:40                         ` Darrick J. Wong
2016-08-17 20:02             ` Johannes Stezenbach
2016-08-18  7:44               ` Török Edwin
2016-07-26  4:55   ` Christian Kujau
2016-07-28  0:00     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160808160818.GA9515@thunk.org \
    --to=tytso@mit.edu \
    --cc=darrick.wong@oracle.com \
    --cc=edwin@etorok.net \
    --cc=js@sig21.net \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.