diff for duplicates of <20160808164828.GH12649@leverpostej> diff --git a/a/1.txt b/N1/1.txt index 5f5c369..75ab106 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -42,23 +42,3 @@ On Mon, Aug 08, 2016 at 12:03:38PM -0400, Chris Metcalf wrote: > ret > ENDPROC(cpu_do_idle) > + .popsection - -From a quick scan it looks like we only call this with interrupts -disabled, and we have no NMI. So shouldn't we be annotating -arch_cpu_idle(), which calls this and subsequently enables interrupts? - -I'm also not sure what you need to do for PSCI, which is the preferred -(FW-backed) idle mechanism for arm64. The infrastrucure for that is -spread over a few files: - - arch/arm64/kernel/sleep.S - arch/arm64/kernel/smccc-call.S - arch/arm64/kernel/suspend.c - drivers/cpuidle/cpuidle-arm.c - drivers/firmware/psci.c - -I'm not sure where we'd be an an interruptible state, and therefore I'm -not immediately sure what we should annotate. - -Thanks, -Mark. diff --git a/a/content_digest b/N1/content_digest index 85478ef..20ca784 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -63,26 +63,6 @@ "> \twfi\n" "> \tret\n" "> ENDPROC(cpu_do_idle)\n" - "> +\t.popsection\n" - "\n" - "From a quick scan it looks like we only call this with interrupts\n" - "disabled, and we have no NMI. So shouldn't we be annotating\n" - "arch_cpu_idle(), which calls this and subsequently enables interrupts?\n" - "\n" - "I'm also not sure what you need to do for PSCI, which is the preferred\n" - "(FW-backed) idle mechanism for arm64. The infrastrucure for that is\n" - "spread over a few files:\n" - "\n" - " arch/arm64/kernel/sleep.S\n" - " arch/arm64/kernel/smccc-call.S\n" - " arch/arm64/kernel/suspend.c\n" - " drivers/cpuidle/cpuidle-arm.c\n" - " drivers/firmware/psci.c\n" - "\n" - "I'm not sure where we'd be an an interruptible state, and therefore I'm\n" - "not immediately sure what we should annotate.\n" - "\n" - "Thanks,\n" - Mark. + "> +\t.popsection" -e4e507510e0064bc080b7c09f0e3d3e2a9edbbd1938f8050fba86975f88685aa +6de7ecd7471d3b0d64933895b56a6051c2a6dfc65804a49bc24fb95e75f78376
diff --git a/a/1.txt b/N2/1.txt index 5f5c369..e7dfd07 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -43,7 +43,7 @@ On Mon, Aug 08, 2016 at 12:03:38PM -0400, Chris Metcalf wrote: > ENDPROC(cpu_do_idle) > + .popsection -From a quick scan it looks like we only call this with interrupts +>From a quick scan it looks like we only call this with interrupts disabled, and we have no NMI. So shouldn't we be annotating arch_cpu_idle(), which calls this and subsequently enables interrupts? diff --git a/a/content_digest b/N2/content_digest index 85478ef..beb2c14 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,23 +1,9 @@ "ref\01470672218-16059-1-git-send-email-cmetcalf@mellanox.com\0" "ref\01470672218-16059-5-git-send-email-cmetcalf@mellanox.com\0" - "From\0Mark Rutland <mark.rutland@arm.com>\0" - "Subject\0Re: [PATCH v7 4/4] nmi_backtrace: generate one-line reports for idle cpus\0" + "From\0mark.rutland@arm.com (Mark Rutland)\0" + "Subject\0[PATCH v7 4/4] nmi_backtrace: generate one-line reports for idle cpus\0" "Date\0Mon, 8 Aug 2016 17:48:28 +0100\0" - "To\0Chris Metcalf <cmetcalf@mellanox.com>" - " lorenzo.pieralisi@arm.com\0" - "Cc\0Peter Zijlstra <peterz@infradead.org>" - Rafael J. Wysocki <rjw@rjwysocki.net> - Petr Mladek <pmladek@suse.com> - Russell King <linux@arm.linux.org.uk> - Thomas Gleixner <tglx@linutronix.de> - Aaron Tomlin <atomlin@redhat.com> - Ingo Molnar <mingo@redhat.com> - Andrew Morton <akpm@osdl.org> - Daniel Thompson <daniel.thompson@linaro.org> - x86@kernel.org - linux-arm-kernel@lists.infradead.org - linux-kernel@vger.kernel.org - " linux-arch@vger.kernel.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi,\n" @@ -65,7 +51,7 @@ "> ENDPROC(cpu_do_idle)\n" "> +\t.popsection\n" "\n" - "From a quick scan it looks like we only call this with interrupts\n" + ">From a quick scan it looks like we only call this with interrupts\n" "disabled, and we have no NMI. So shouldn't we be annotating\n" "arch_cpu_idle(), which calls this and subsequently enables interrupts?\n" "\n" @@ -85,4 +71,4 @@ "Thanks,\n" Mark. -e4e507510e0064bc080b7c09f0e3d3e2a9edbbd1938f8050fba86975f88685aa +67ca2c841de9bdbf631f62655d60af2cfed54e877acb8b6af541447dfee007ba
diff --git a/a/1.txt b/N3/1.txt index 5f5c369..e7dfd07 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -43,7 +43,7 @@ On Mon, Aug 08, 2016 at 12:03:38PM -0400, Chris Metcalf wrote: > ENDPROC(cpu_do_idle) > + .popsection -From a quick scan it looks like we only call this with interrupts +>From a quick scan it looks like we only call this with interrupts disabled, and we have no NMI. So shouldn't we be annotating arch_cpu_idle(), which calls this and subsequently enables interrupts? diff --git a/a/content_digest b/N3/content_digest index 85478ef..a5383b5 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -65,7 +65,7 @@ "> ENDPROC(cpu_do_idle)\n" "> +\t.popsection\n" "\n" - "From a quick scan it looks like we only call this with interrupts\n" + ">From a quick scan it looks like we only call this with interrupts\n" "disabled, and we have no NMI. So shouldn't we be annotating\n" "arch_cpu_idle(), which calls this and subsequently enables interrupts?\n" "\n" @@ -85,4 +85,4 @@ "Thanks,\n" Mark. -e4e507510e0064bc080b7c09f0e3d3e2a9edbbd1938f8050fba86975f88685aa +8731af39fbdd66cebbb232e69e9f11f5a12aa902b37d181dfc5897d215a48288
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.