From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 0/7] Minor DP aux transaction fixes Date: Tue, 9 Aug 2016 08:11:26 +0200 Message-ID: <20160809061126.GF6232@phenom.ffwll.local> References: <1470443443-27252-1-git-send-email-cpaul@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: Tom St Denis , Jammy Zhou , xorg-driver-ati@lists.freedesktop.org, LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Ken Wang , Lyude , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: amd-gfx.lists.freedesktop.org T24gTW9uLCBBdWcgMDgsIDIwMTYgYXQgMDE6MzA6MzdQTSAtMDQwMCwgQWxleCBEZXVjaGVyIHdy b3RlOgo+IE9uIEZyaSwgQXVnIDUsIDIwMTYgYXQgODozMCBQTSwgTHl1ZGUgPGNwYXVsQHJlZGhh dC5jb20+IHdyb3RlOgo+ID4gV2hpbGUgSSB3YXMgaW52ZXN0aWdhdGluZyBhbiB1bnJlbGF0ZWQg YnVnIG9uIHRoZSByYWRlb24gZHJpdmVyLCBJIG5vdGljZWQgdGhhdAo+ID4gaXQncyBiZWNvbWUg cmF0aGVyIGRpZmZpY3VsdCB0byBhY3R1YWxseSByZWFkIHRocm91Z2ggZG1lc2cgd2l0aCBkcm0u ZGVidWcKPiA+IHR1cm5lZCBvbiwgb24gYWNjb3VudCBvZiB0aGUgaHVnZSBudW1iZXIgb2YgbWVz c2FnZXMgd2UgZW5kIHVwIHByaW50aW5nIGZyb20KPiA+IGZhaWxlZCBEUCBhdXggdHJhbnNhY3Rp b25zIHRoYXQgaGFwcGVuIGV2ZXJ5IHRpbWUgd2UgcmVwcm9iZSBlYWNoIGNvbm5lY3Rvci4KPiA+ Cj4gPiBUaW1lZCBvdXQgdHJhbnNhY3Rpb25zIGFyZSByZWxhdGl2ZWx5IG5vcm1hbCwgYW5kIGFz IHdlbGwgdGhlcmUncyBhIGxvdCBvZgo+ID4gcGxhY2VzIGluIHJhZGVvbi9hbWRncHUgd2hlcmUg d2UncmUgcHJpbnRpbmcgcmVkdW5kYW50IGRlYnVnZ2luZyBpbmZvcm1hdGlvbgo+ID4gZG96ZW5z IG9mIHRpbWVzIGVhY2ggdGltZSB3ZSBhdHRlbXB0IGEgRFAgYXV4IHRyYW5zYWN0aW9ucy4KPiA+ Cj4gPiBBZGRpdGlvbmFsbHksIEkndmUgcmVtb3ZlZCBzb21lIG9mIHRoZSByZXRyeSBsb29wcyBp biBhbWRncHUvcmFkZW9uLiBUaGVzZSB3ZXJlCj4gPiBkZWZpbml0ZWx5IHVzZWZ1bCBhdCBvbmUg cG9pbnQsIGJ1dCBzaW5jZSB3ZSBub3cgcmV0cnkgYW55IGZhaWxlZCBhdXgKPiA+IHRyYW5zYWN0 aW9uIHVuY29uZGl0aW9uYWxseSBpbiBEUk0ncyBkcCBoZWxwZXJzIHRoZXkgZG9uJ3Qgc2VydmUg bXVjaCBwdXJwb3NlCj4gPiBvdGhlciB0aGVuIHRvIG1ha2UgZmFpbGluZyBhdXggdHJhbnNhY3Rp b25zIHRha2UgYSBsb3QgbW9yZSB0aW1lIHRoZW4gdGhleSBuZWVkCj4gPiB0by4KPiAKPiBJJ3Zl IGFwcGxpZWQgdGhlIGFtZGdwdSBhbmQgcmFkZW9uIHBhdGNoZXMuICBGb3IgdGhlIGRybSBwYXRj aGVzLCBJCj4gY2FuIGVpdGhlciB0YWtlIHRoZW0gdGhyb3VnaCBteSB0cmVlIG9yIHZpYSBkcm0t bWlzYy4KCkkgYXBwbGllZCB0aGUgMiBjb3JlIHBhdGNoZXMgdG8gZHJtLW1pc2MsIHRoYW5rcy4K LURhbmllbAoKPiAKPiBBbGV4Cj4gCj4gPgo+ID4gTHl1ZGUgKDcpOgo+ID4gICBkcm0vZHBfaGVs cGVyOiBQcmludCBmaXJzdCBlcnJvciByZWNlaXZlZCBvbiBmYWlsdXJlIGluCj4gPiAgICAgZHJt X2RwX2RwY2RfYWNjZXNzKCkKPiA+ICAgZHJtL3JhZGVvbjogRG9uJ3QgcHJpbnQgZXJyb3Igb24g YXV4IHRyYW5zYWN0aW9uIHRpbWVvdXRzCj4gPiAgIGRybS9yYWRlb246IERvbid0IHJldHJ5IDcg dGltZXMgaW4gcmFkZW9uX2RwX2RwY2QoKQo+ID4gICBkcm0vYW1kZ3B1OiBEb24ndCBwcmludCBl cnJvciBvbiBhdXggdHJhbnNhY3Rpb24gdGltZW91dHMKPiA+ICAgZHJtL2FtZGdwdTogRG9uJ3Qg cmV0cnkgNyB0aW1lcyBpbiBhbWRncHVfYXRvbWJpb3NfZHBfZ2V0X2RwY2QoKQo+ID4gICBkcm06 IEFkZCByYXRlbGltaXRlZCB2ZXJzaW9ucyBvZiB0aGUgRFJNX0RFQlVHKiBtYWNyb3MKPiA+ICAg ZHJtL2RwX2hlbHBlcjogUmF0ZSBsaW1pdCB0aW1lb3V0IGVycm9ycyBmcm9tIGRybV9kcF9pMmNf ZG9fbXNnKCkKPiA+Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYXRvbWJpb3NfZHAu YyB8IDIyICsrKysrKysrKystLS0tLS0tLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Rw X2hlbHBlci5jICAgICAgICAgIHwgMTQgKysrKysrKysrKysrLS0KPiA+ICBkcml2ZXJzL2dwdS9k cm0vcmFkZW9uL2F0b21iaW9zX2RwLmMgICAgIHwgMjEgKysrKysrKysrKy0tLS0tLS0tLS0tCj4g PiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZHBfYXV4Y2guYyB8ICAxIC0KPiA+ICBp bmNsdWRlL2RybS9kcm1QLmggICAgICAgICAgICAgICAgICAgICAgIHwgMzAgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrCj4gPiAgNSBmaWxlcyBjaGFuZ2VkLCA2MiBpbnNlcnRpb25zKCsp LCAyNiBkZWxldGlvbnMoLSkKPiA+Cj4gPiAtLQo+ID4gMi43LjQKPiA+Cj4gPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gZHJpLWRldmVsIG1haWxp bmcgbGlzdAo+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwg VmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbcHIGLg (ORCPT ); Tue, 9 Aug 2016 02:11:36 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35912 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752249AbcHIGLb (ORCPT ); Tue, 9 Aug 2016 02:11:31 -0400 Date: Tue, 9 Aug 2016 08:11:26 +0200 From: Daniel Vetter To: Alex Deucher Cc: Lyude , Tom St Denis , Jammy Zhou , xorg-driver-ati@lists.freedesktop.org, LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Ken Wang , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH 0/7] Minor DP aux transaction fixes Message-ID: <20160809061126.GF6232@phenom.ffwll.local> Mail-Followup-To: Alex Deucher , Lyude , Tom St Denis , Jammy Zhou , xorg-driver-ati@lists.freedesktop.org, LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Ken Wang , Christian =?iso-8859-1?Q?K=F6nig?= References: <1470443443-27252-1-git-send-email-cpaul@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2016 at 01:30:37PM -0400, Alex Deucher wrote: > On Fri, Aug 5, 2016 at 8:30 PM, Lyude wrote: > > While I was investigating an unrelated bug on the radeon driver, I noticed that > > it's become rather difficult to actually read through dmesg with drm.debug > > turned on, on account of the huge number of messages we end up printing from > > failed DP aux transactions that happen every time we reprobe each connector. > > > > Timed out transactions are relatively normal, and as well there's a lot of > > places in radeon/amdgpu where we're printing redundant debugging information > > dozens of times each time we attempt a DP aux transactions. > > > > Additionally, I've removed some of the retry loops in amdgpu/radeon. These were > > definitely useful at one point, but since we now retry any failed aux > > transaction unconditionally in DRM's dp helpers they don't serve much purpose > > other then to make failing aux transactions take a lot more time then they need > > to. > > I've applied the amdgpu and radeon patches. For the drm patches, I > can either take them through my tree or via drm-misc. I applied the 2 core patches to drm-misc, thanks. -Daniel > > Alex > > > > > Lyude (7): > > drm/dp_helper: Print first error received on failure in > > drm_dp_dpcd_access() > > drm/radeon: Don't print error on aux transaction timeouts > > drm/radeon: Don't retry 7 times in radeon_dp_dpcd() > > drm/amdgpu: Don't print error on aux transaction timeouts > > drm/amdgpu: Don't retry 7 times in amdgpu_atombios_dp_get_dpcd() > > drm: Add ratelimited versions of the DRM_DEBUG* macros > > drm/dp_helper: Rate limit timeout errors from drm_dp_i2c_do_msg() > > > > drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 22 ++++++++++------------ > > drivers/gpu/drm/drm_dp_helper.c | 14 ++++++++++++-- > > drivers/gpu/drm/radeon/atombios_dp.c | 21 ++++++++++----------- > > drivers/gpu/drm/radeon/radeon_dp_auxch.c | 1 - > > include/drm/drmP.h | 30 ++++++++++++++++++++++++++++++ > > 5 files changed, 62 insertions(+), 26 deletions(-) > > > > -- > > 2.7.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch