From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Date: Tue, 09 Aug 2016 12:05:31 +0000 Subject: Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test Message-Id: <20160809120531.GY8132@piout.net> List-Id: References: <1470743907-11498-1-git-send-email-christophe.jaillet@wanadoo.fr> In-Reply-To: <1470743907-11498-1-git-send-email-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/08/2016 at 13:58:27 +0200, Christophe JAILLET wrote : > It is likely that checking the result of 'pcf2123_write_reg' is expected > here. > Also fix a small style issue. The '{' at the beginning of the function > is misplaced. > > Fixes: 809b453b76e15 ("rtc: pcf2123: clean up writes to the rtc chip") > > Signed-off-by: Christophe JAILLET > --- > drivers/rtc/rtc-pcf2123.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id r197si103420wmf.2.2016.08.09.05.05.32 for ; Tue, 09 Aug 2016 05:05:32 -0700 (PDT) Date: Tue, 9 Aug 2016 14:05:31 +0200 From: Alexandre Belloni To: Christophe JAILLET Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test Message-ID: <20160809120531.GY8132@piout.net> References: <1470743907-11498-1-git-send-email-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1470743907-11498-1-git-send-email-christophe.jaillet@wanadoo.fr> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 09/08/2016 at 13:58:27 +0200, Christophe JAILLET wrote : > It is likely that checking the result of 'pcf2123_write_reg' is expected > here. > Also fix a small style issue. The '{' at the beginning of the function > is misplaced. > > Fixes: 809b453b76e15 ("rtc: pcf2123: clean up writes to the rtc chip") > > Signed-off-by: Christophe JAILLET > --- > drivers/rtc/rtc-pcf2123.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591AbcHIMFg (ORCPT ); Tue, 9 Aug 2016 08:05:36 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46877 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751605AbcHIMFe (ORCPT ); Tue, 9 Aug 2016 08:05:34 -0400 Date: Tue, 9 Aug 2016 14:05:31 +0200 From: Alexandre Belloni To: Christophe JAILLET Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test Message-ID: <20160809120531.GY8132@piout.net> References: <1470743907-11498-1-git-send-email-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470743907-11498-1-git-send-email-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2016 at 13:58:27 +0200, Christophe JAILLET wrote : > It is likely that checking the result of 'pcf2123_write_reg' is expected > here. > Also fix a small style issue. The '{' at the beginning of the function > is misplaced. > > Fixes: 809b453b76e15 ("rtc: pcf2123: clean up writes to the rtc chip") > > Signed-off-by: Christophe JAILLET > --- > drivers/rtc/rtc-pcf2123.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com