From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56241)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bX61y-0000vC-5i
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:21:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bX61s-0002Bo-5P
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:21:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43080)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bX61r-0002BU-Vx
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:21:08 -0400
Date: Tue, 9 Aug 2016 20:21:00 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160809122100.GA4201@pxdev.xzpeter.org>
References: <1470127147-12442-1-git-send-email-davidkiarie4@gmail.com>
	<1470127147-12442-4-git-send-email-davidkiarie4@gmail.com>
	<20160809054434.GA3979@pxdev.xzpeter.org>
	<CABdVeABrGUmkGgDYMEvVLPR-6wfRipha57Y4iDzLrqY50v-SbQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CABdVeABrGUmkGgDYMEvVLPR-6wfRipha57Y4iDzLrqY50v-SbQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Kiarie <davidkiarie4@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, rkrcmar@redhat.com, Jan Kiszka <jan.kiszka@web.de>, Valentine Sinitsyn <valentine.sinitsyn@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Tue, Aug 09, 2016 at 03:07:43PM +0300, David Kiarie wrote:
> On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu <peterx@redhat.com> wrote:
> 
> > On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie wrote:
> >
> > [...]
> >
> >
> Hi Peter.
> 
> Most of your comments are valid thought some are subjective :-). I'm
> covering most if not all of them on next version (should coming shortly).

Hi, David,

I think for most subjective comments, I was using "Nit:" as prefix.
Most of the other comments should not? ;)

For endian issue, I am not sure whether that's important, since I
don't know whether there will be anyone run x86_64 on e.g. big endian
machines with a AMD IOMMU... For the other comments besides "nit" and
"endianess" issues, I would like to hear your opinion if you disagree
on any of them (so I can learn as well if I made any mistake). :)

Thanks,

-- peterx