From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bX6SF-00064m-CN
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:48:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bX6SB-00005y-4l
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:48:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35232)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bX6SA-00005t-V9
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:48:19 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 92C8661E56
	for <qemu-devel@nongnu.org>; Tue,  9 Aug 2016 12:48:17 +0000 (UTC)
Date: Tue, 9 Aug 2016 13:48:14 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160809124814.GH1530@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <20160808141439.16908-1-marcandre.lureau@redhat.com>
	<20160808141439.16908-13-marcandre.lureau@redhat.com>
	<877fbqglj6.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <877fbqglj6.fsf@dusky.pond.sub.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org

On Tue, Aug 09, 2016 at 02:43:41PM +0200, Markus Armbruster wrote:
> marcandre.lureau@redhat.com writes:
>=20
> > From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> >
> > Replace the old manual dispatch and validation code by the generic on=
e
> > provided by qapi common code.
> >
> > Note that it is now possible to call the following commands that used=
 to
> > be disabled by compile-time conditionals:
> > - dump-skeys
> > - query-spice
> > - rtc-reset-reinjection
> > - query-gic-capabilities
> >
> > Their fallback functions return an appropriate "feature disabled" err=
or.
> >
> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>=20
> Means query-qmp-schema no longer shows whether these commands are
> supported, doesn't it?
>=20
> Eric, could this create difficulties for libvirt or other introspection
> users?

Libvirt doesn't use  query-qmp-schema at all - we just blindly invoke
the commands and catch error. That said I agree with your point though.
It seems pretty undesirable for query-qmp-schema to report that the
commands exist when they clearly don't really exist in any usable
manner.

Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|